Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: fix typos #27580

Closed
wants to merge 1 commit into from

Conversation

@gengjiawen
Copy link
Contributor

commented May 6, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Show resolved Hide resolved src/node_binding.cc Outdated

@gengjiawen gengjiawen force-pushed the gengjiawen:typos branch from 87a44fd to e878d23 May 6, 2019

@gengjiawen gengjiawen force-pushed the gengjiawen:typos branch from e878d23 to f179c82 May 6, 2019

@cjihrig

cjihrig approved these changes May 6, 2019

@Trott

Trott approved these changes May 6, 2019

@nodejs-github-bot

This comment has been minimized.

@lpinca

lpinca approved these changes May 6, 2019

@danbev

This comment has been minimized.

Copy link
Member

commented May 9, 2019

Re-run of failing node-test-commit-osx (✔️)

@danbev

This comment has been minimized.

Copy link
Member

commented May 9, 2019

Landed in 3b48ce6.

@danbev danbev closed this May 9, 2019

danbev added a commit that referenced this pull request May 9, 2019

src: fix typos
PR-URL: #27580
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

targos added a commit that referenced this pull request May 9, 2019

src: fix typos
PR-URL: #27580
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.