Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: export OpenSSL UI symbols #27586

Closed

Conversation

@sam-github
Copy link
Member

commented May 6, 2019

Node.js compiles them, their existence is indicated by OpenSSL header
defines, but they can't be linked to on Windows because their symbols
are not exported. Export them.

Fixes: #27494

See #27494 (comment) for more info.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@Trott

Trott approved these changes May 6, 2019

@mscdex

This comment has been minimized.

Copy link
Contributor

commented May 6, 2019

I think build might be a better subsystem prefix for the commit message.

build: export OpenSSL UI symbols
Node.js compiles them, their existence is indicated by OpenSSL header
defines, but they can't be linked to on Windows because their symbols
are not exported. Export them.

Fixes: #27494

@sam-github sam-github force-pushed the sam-github:export-openssl-ui-symbols branch from 4e40c1d to 666a13d May 6, 2019

@nodejs-github-bot

This comment has been minimized.

@mscdex mscdex changed the title tls: export OpenSSL UI symbols build: export OpenSSL UI symbols May 6, 2019

@cjihrig

cjihrig approved these changes May 7, 2019

@nkochakian

This comment has been minimized.

Copy link

commented May 7, 2019

Looks good. This matches the change I made when testing.

@lpinca

lpinca approved these changes May 7, 2019

@mhdawson
Copy link
Member

left a comment

LGTM

@sam-github

This comment has been minimized.

Copy link
Member Author

commented May 9, 2019

Landed in b9a3103

@sam-github sam-github closed this May 9, 2019

@sam-github sam-github deleted the sam-github:export-openssl-ui-symbols branch May 9, 2019

sam-github added a commit that referenced this pull request May 9, 2019

build: export OpenSSL UI symbols
Node.js compiles them, their existence is indicated by OpenSSL header
defines, but they can't be linked to on Windows because their symbols
are not exported. Export them.

Fixes: #27494

PR-URL: #27586
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

targos added a commit that referenced this pull request May 10, 2019

build: export OpenSSL UI symbols
Node.js compiles them, their existence is indicated by OpenSSL header
defines, but they can't be linked to on Windows because their symbols
are not exported. Export them.

Fixes: #27494

PR-URL: #27586
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.