Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update llhttp to 1.1.3 #27595

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
6 participants
@indutny
Copy link
Member

commented May 7, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

cc @nodejs/http @nodejs/collaborators @addaleax

@nodejs-github-bot

This comment has been minimized.

@indutny indutny referenced this pull request May 7, 2019

Merged

v12.2.0 proposal #27578

@indutny indutny requested review from cjihrig and addaleax May 7, 2019

@rvagg

This comment has been minimized.

Copy link
Member

commented May 7, 2019

a description would be helpful, otherwise a change from a 0 to 1 in a table of generated code is going to take some supreme confidence to review

@indutny

This comment has been minimized.

Copy link
Member Author

commented May 7, 2019

@rvagg I agree. The change before compilation is: nodejs/llhttp@ba06644

This addresses #27584


(I should do changelogs in llhttp... I should do changelogs in llhttp...)

@rvagg

This comment has been minimized.

Copy link
Member

commented May 7, 2019

oof, that's rough. +1 to fast-track from me.

@rvagg

rvagg approved these changes May 7, 2019

@targos

targos approved these changes May 7, 2019

@nodejs-github-bot

This comment has been minimized.

@rvagg

This comment has been minimized.

Copy link
Member

commented May 7, 2019

@indutny btw https://github.com/nodejs/changelog-maker is a good tool for making changelogs and you get a bonus because llhttp follows all of the metadata rules it likes so your changelogs will look like Node's.

Here's your 1.1.3 changelog for example:

changelog-maker --start-ref=v1.1.2 --filter-release

@cjihrig

cjihrig approved these changes May 7, 2019

@targos

This comment has been minimized.

Copy link
Member

commented May 7, 2019

Landed in c476daf

@targos targos closed this May 7, 2019

targos added a commit that referenced this pull request May 7, 2019

deps: update llhttp to 1.1.3
Fixes: #27584
PR-URL: #27595
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

targos added a commit that referenced this pull request May 7, 2019

deps: update llhttp to 1.1.3
Fixes: #27584
PR-URL: #27595
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

targos added a commit that referenced this pull request May 7, 2019

2019-05-07, Version 12.2.0 (Current)
Notable changes:

* deps:
  * Updated llhttp to 1.1.3. This fixes a bug that made Node.js' HTTP
    parser refuse any request URL that contained the "|" (vertical bar)
    character. #27595
* tls:
  * Added an `enableTrace()` method to `TLSSocket` and an `enableTrace`
    option to `tls.createServer()`. When enabled, TSL packet trace
    information is written to `stderr`. This can be used to debug TLS
    connection problems. #27497
    #27376
* cli:
  * Added a `--trace-tls` command-line flag that enables tracing of TLS
    connections without the need to modify existing application code.
    #27497
  * Added a `--cpu-prof-interval` command-line flag. It can be used to
    specify the sampling interval for the CPU profiles generated by
    `--cpu-prof`. #27535
* module:
  * Added the `createRequire()` method. It allows to create a require
    function from a file URL object, a file URL string or an absolute
    path string. The existing `createRequireFromPath()` method is now
    deprecated #27405.
  * Throw on `require('./path.mjs')`. This is technically a breaking
    change that should have landed with Node.js 12.0.0. It is necessary
    to have this to keep the possibility for a future minor version to
    load ES Modules with the require function.
    #27417
* repl:
  * The REPL now supports multi-line statements using `BigInt` literals
    as well as public and private class fields and methods.
    #27400
  * The REPL now supports tab autocompletion of file paths with `fs`
    methods. #26648
* meta:
  * Added Christian Clauss (https://github.com/cclauss) to
    collaborators. #27554

PR-URL: #27578

targos added a commit that referenced this pull request May 7, 2019

2019-05-07, Version 12.2.0 (Current)
Notable changes:

* deps:
  * Updated llhttp to 1.1.3. This fixes a bug that made Node.js' HTTP
    parser refuse any request URL that contained the "|" (vertical bar)
    character. #27595
* tls:
  * Added an `enableTrace()` method to `TLSSocket` and an `enableTrace`
    option to `tls.createServer()`. When enabled, TSL packet trace
    information is written to `stderr`. This can be used to debug TLS
    connection problems. #27497
    #27376
* cli:
  * Added a `--trace-tls` command-line flag that enables tracing of TLS
    connections without the need to modify existing application code.
    #27497
  * Added a `--cpu-prof-interval` command-line flag. It can be used to
    specify the sampling interval for the CPU profiles generated by
    `--cpu-prof`. #27535
* module:
  * Added the `createRequire()` method. It allows to create a require
    function from a file URL object, a file URL string or an absolute
    path string. The existing `createRequireFromPath()` method is now
    deprecated #27405.
  * Throw on `require('./path.mjs')`. This is technically a breaking
    change that should have landed with Node.js 12.0.0. It is necessary
    to have this to keep the possibility for a future minor version to
    load ES Modules with the require function.
    #27417
* repl:
  * The REPL now supports multi-line statements using `BigInt` literals
    as well as public and private class fields and methods.
    #27400
  * The REPL now supports tab autocompletion of file paths with `fs`
    methods. #26648
* meta:
  * Added Christian Clauss (https://github.com/cclauss) to
    collaborators. #27554

PR-URL: #27578
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.