Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assert: remove unused code #27676

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
6 participants
@BridgeAR
Copy link
Member

commented May 13, 2019

Those two operators are not used.

This is an alternative to #27635. @Trott

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
assert: remove unused code
Those two operators are not used.
@nodejs-github-bot

This comment has been minimized.

@3mard

3mard approved these changes May 13, 2019

@Trott

Trott approved these changes May 13, 2019

@Trott Trott added the author ready label May 13, 2019

@nodejs-github-bot

This comment has been minimized.

@Trott Trott referenced this pull request May 13, 2019

Closed

assert,test: complete coverage for AssertionError #27635

3 of 3 tasks complete
@ZYSzys

ZYSzys approved these changes May 15, 2019

BridgeAR added a commit to BridgeAR/node that referenced this pull request May 16, 2019

assert: remove unused code
Those two operators are not used.

PR-URL: nodejs#27676
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BridgeAR

This comment has been minimized.

Copy link
Member Author

commented May 16, 2019

Landed in 35fc1b4 🎉

@BridgeAR BridgeAR closed this May 16, 2019

targos added a commit that referenced this pull request May 17, 2019

assert: remove unused code
Those two operators are not used.

PR-URL: #27676
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

@BridgeAR BridgeAR referenced this pull request May 21, 2019

Merged

v12.3.0 proposal #27799

4 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.