Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: DRY isRequireCall() in lint rules #27680

Merged
merged 1 commit into from May 15, 2019

Conversation

@cjihrig
Copy link
Contributor

commented May 13, 2019

This commit makes isRequireCall() a reusable utility function for core's custom ESLint rules.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
@nodejs-github-bot

This comment has been minimized.

@Trott
Trott approved these changes May 13, 2019

@cjihrig cjihrig force-pushed the cjihrig:lint-rules branch from 93bf80d to 6fc172a May 14, 2019

@nodejs-github-bot

This comment has been minimized.

Copy link

commented May 14, 2019

@Trott Trott added the author ready label May 14, 2019

@ZYSzys
ZYSzys approved these changes May 15, 2019
tools: DRY isRequireCall() in lint rules
This commit makes isRequireCall() a reusable utility
function for core's custom ESLint rules.

PR-URL: #27680
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>

@cjihrig cjihrig force-pushed the cjihrig:lint-rules branch from 6fc172a to 03d4353 May 15, 2019

@cjihrig cjihrig merged commit 03d4353 into nodejs:master May 15, 2019

1 of 2 checks passed

Travis CI - Pull Request Build Errored
Details
Travis CI - Branch Build Passed
Details

@cjihrig cjihrig deleted the cjihrig:lint-rules branch May 15, 2019

targos added a commit that referenced this pull request May 17, 2019
tools: DRY isRequireCall() in lint rules
This commit makes isRequireCall() a reusable utility
function for core's custom ESLint rules.

PR-URL: #27680
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@BridgeAR BridgeAR referenced this pull request May 21, 2019
4 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.