Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade to libuv 1.29.1 #27718

Merged
merged 1 commit into from May 21, 2019

Conversation

Projects
None yet
9 participants
@cjihrig
Copy link
Contributor

commented May 15, 2019

Notable changes:

  • uv_get_constrained_memory() has been added.
  • A race condition in uv_async_send() has been fixed.
  • uv_get_free_memory() and uv_get_total_memory() now read from
    /proc/meminfo, which should improve correctness when called
    from inside an lxc container.
  • A failed assertion in uv_fs_poll_stop() has been fixed.
  • A bug in MAC addresses for IP-aliases has been fixed.

Fixes: #27170
Fixes: #27493

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@nodejs-github-bot

This comment has been minimized.

@cjihrig cjihrig force-pushed the cjihrig:libuv branch from 0a1012d to 393fc55 May 15, 2019

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@refack

refack approved these changes May 15, 2019

@bnoordhuis
Copy link
Member

left a comment

LGTM. Also closes out #27493.

@nodejs-github-bot

This comment has been minimized.

Copy link

commented May 16, 2019

@cjihrig

This comment has been minimized.

Copy link
Contributor Author

commented May 17, 2019

@bnoordhuis should we hold off on landing this until libuv/libuv#2297 is resolved?

@Trott

Trott approved these changes May 17, 2019

Copy link
Member

left a comment

Rubber-stamp LGTM

@bnoordhuis

This comment has been minimized.

Copy link
Member

commented May 20, 2019

should we hold off on landing this until libuv/libuv#2297 is resolved?

I think that would be a good idea. I don't fully understand yet what's causing it.

@Trott Trott added the blocked label May 20, 2019

@cjihrig cjihrig changed the title deps: upgrade to libuv 1.29.0 deps: upgrade to libuv 1.29.1 May 21, 2019

@cjihrig cjihrig removed the blocked label May 21, 2019

@cjihrig cjihrig force-pushed the cjihrig:libuv branch from 393fc55 to f865541 May 21, 2019

cjihrig added a commit to cjihrig/node-1 that referenced this pull request May 21, 2019

deps: upgrade to libuv 1.29.1
Notable changes:

- uv_get_constrained_memory() has been added.
- A race condition in uv_async_send() has been fixed.
- uv_get_free_memory() and uv_get_total_memory() now read from
  /proc/meminfo, which should improve correctness when called
  from inside an lxc container.
- A failed assertion in uv_fs_poll_stop() has been fixed.
- A bug in MAC addresses for IP-aliases has been fixed.

Fixes: nodejs#27170
Fixes: nodejs#27493
PR-URL: nodejs#27718
@nodejs-github-bot

This comment has been minimized.

Copy link

commented May 21, 2019

@cjihrig

This comment has been minimized.

Copy link
Contributor Author

commented May 21, 2019

This is now 1.29.1.

@refack

refack approved these changes May 21, 2019

Copy link
Member

left a comment

reify

deps: upgrade to libuv 1.29.1
Notable changes:

- uv_get_constrained_memory() has been added.
- A race condition in uv_async_send() has been fixed.
- uv_get_free_memory() and uv_get_total_memory() now read from
  /proc/meminfo, which should improve correctness when called
  from inside an lxc container.
- A failed assertion in uv_fs_poll_stop() has been fixed.
- A bug in MAC addresses for IP-aliases has been fixed.

Fixes: #27170
Fixes: #27493
PR-URL: #27718
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@cjihrig cjihrig force-pushed the cjihrig:libuv branch from f865541 to 46d8af5 May 21, 2019

@cjihrig cjihrig merged commit 46d8af5 into nodejs:master May 21, 2019

1 of 2 checks passed

Travis CI - Pull Request Build Errored
Details
Travis CI - Branch Build Passed
Details

@cjihrig cjihrig deleted the cjihrig:libuv branch May 21, 2019

BridgeAR added a commit that referenced this pull request May 22, 2019

deps: upgrade to libuv 1.29.1
Notable changes:

- uv_get_constrained_memory() has been added.
- A race condition in uv_async_send() has been fixed.
- uv_get_free_memory() and uv_get_total_memory() now read from
  /proc/meminfo, which should improve correctness when called
  from inside an lxc container.
- A failed assertion in uv_fs_poll_stop() has been fixed.
- A bug in MAC addresses for IP-aliases has been fixed.

Fixes: #27170
Fixes: #27493
PR-URL: #27718
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@BridgeAR BridgeAR referenced this pull request May 22, 2019

Merged

v12.3.1 proposal #27814

BridgeAR added a commit that referenced this pull request May 22, 2019

2019-05-22, Version v12.3.1 (Current)
Notable changes

* deps:
  * Fix handling of +0/-0 when constant field tracking is enabled
    (Michaël Zasso) #27792
  * Fix `os.freemem()` and `os.totalmem` correctness (cjihrig)
    #27718
* src:
  * Fix v12.3.0 regression that prevents native addons from compiling
    #27804

PR-URL: #27814

BridgeAR added a commit to BridgeAR/node that referenced this pull request May 22, 2019

2019-05-22, Version v12.3.1 (Current)
Notable changes

* deps:
  * Fix handling of +0/-0 when constant field tracking is enabled
    (Michaël Zasso) nodejs#27792
  * Fix `os.freemem()` and `os.totalmem` correctness (cjihrig)
    nodejs#27718
* src:
  * Fix v12.3.0 regression that prevents native addons from compiling
    nodejs#27804

PR-URL: nodejs#27814
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.