Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: allow --interpreted-frames-native-stack in NODE_OPTIONS #27744

Closed
wants to merge 1 commit into from

Conversation

@mmarchini
Copy link
Member

commented May 17, 2019

We have --perf-basic-prof and family in NODE_OPTIONS, but these flags might not give the desired result without --interpreted-frames-native-stack, thus adding this flag in NODE_OPTIONS as well makes sense.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@nodejs-github-bot

This comment was marked as outdated.

@@ -932,6 +932,7 @@ V8 options that are allowed are:
- `--perf-basic-prof-only-functions`
- `--perf-prof`
- `--perf-prof-unwinding-info`
- `--interpreted-frames-native-stack`

This comment has been minimized.

Copy link
@Trott

Trott May 17, 2019

Member

The flags are currently in alphabetical order. Can you move this one to line 930 to maintain alphabetical listing? Or is it better that it be below --perf-* flags?

@Trott
Trott approved these changes May 17, 2019
Copy link
Member

left a comment

LGTM although I'd prefer the flag list be kept alphabetical in cli.md. Not blocking on that though.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@Trott

This comment has been minimized.

@BridgeAR

This comment has been minimized.

Copy link
Member

commented Jun 17, 2019

@mmarchini this needs a rebase.

@BridgeAR BridgeAR removed the author ready label Jun 17, 2019

@mmarchini

This comment has been minimized.

Copy link
Member Author

commented Jun 18, 2019

I'll rebase and address @Trott in the next few days.

@addaleax

This comment has been minimized.

Copy link
Member

commented Aug 25, 2019

Small bump @mmarchini ? :)

@mmarchini mmarchini force-pushed the mmarchini:ifnt-node-options branch from 61e2daa to 59fd2ba Aug 26, 2019

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@mmarchini mmarchini force-pushed the mmarchini:ifnt-node-options branch from 59fd2ba to f078ea1 Aug 27, 2019

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

mmarchini added a commit that referenced this pull request Aug 27, 2019
src: allow --interpreted-frames-native-stack in NODE_OPTIONS
PR-URL: #27744
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@mmarchini

This comment has been minimized.

Copy link
Member Author

commented Aug 27, 2019

Landed in 0150490 🎉

Thank you for the reviews and sorry for the delay!

@mmarchini mmarchini closed this Aug 27, 2019

BridgeAR added a commit that referenced this pull request Sep 3, 2019
src: allow --interpreted-frames-native-stack in NODE_OPTIONS
PR-URL: #27744
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR BridgeAR referenced this pull request Sep 3, 2019
BridgeAR added a commit that referenced this pull request Sep 4, 2019
src: allow --interpreted-frames-native-stack in NODE_OPTIONS
PR-URL: #27744
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
src: allow --interpreted-frames-native-stack in NODE_OPTIONS
PR-URL: nodejs#27744
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
src: allow --interpreted-frames-native-stack in NODE_OPTIONS
PR-URL: nodejs#27744
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.