Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add version info for types #27754

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@mhdawson
Copy link
Member

commented May 17, 2019

Add version info for types in N-API doc.

Fixes: ttps://github.com//issues/27486

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
@nodejs-github-bot

This comment has been minimized.

@mhdawson mhdawson force-pushed the mhdawson:napi-doc-again2 branch from 87e3b57 to e165aa0 May 17, 2019

doc: add version info for types
Add version info for types in N-API doc.

Fixes: #27486

@mhdawson mhdawson force-pushed the mhdawson:napi-doc-again2 branch from e165aa0 to 024875e May 17, 2019

@BridgeAR
Copy link
Member

left a comment

RSLGTM

@Trott

Trott approved these changes May 20, 2019

Copy link
Member

left a comment

Also rubber-stamp LGTM

@Trott

This comment has been minimized.

Copy link
Member

commented May 26, 2019

Landed in dd6481a

@Trott Trott closed this May 26, 2019

Trott added a commit to Trott/io.js that referenced this pull request May 26, 2019

doc: add version info for types
Add version info for types in N-API doc.

PR-URL: nodejs#27754
Fixes: nodejs#27486
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>

targos added a commit that referenced this pull request May 28, 2019

doc: add version info for types
Add version info for types in N-API doc.

PR-URL: #27754
Fixes: #27486
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>

@targos targos referenced this pull request Jun 3, 2019

Merged

v12.4.0 release proposal #28040

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.