Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
src: remove util-inl.h include in node.h #27804
@BridgeAR It would be awesome if you could push out 12.3.1 with that soon, it completely breaks non-N-API addon compilation.
@targos I think CITGM uses
referenced this pull request
May 22, 2019
It would be good to get #12231 going again. I added the broken includes because some test/cctest code was failing to build, code that included only (I thought at the time) "node.h", leading me to the wrong conclusion that those headers were expected as part of the node API. Building addon tests like actual addons would be very helpful.
@targos Sorry for the trouble, and thanks for doing a fixup release.