Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

child_process: move exports to bottom for better code style #27845

Closed
wants to merge 1 commit into from

Conversation

@Himself65
Copy link
Contributor

commented May 24, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@Himself65 Himself65 marked this pull request as ready for review May 24, 2019

lib/child_process.js Outdated Show resolved Hide resolved

@Himself65 Himself65 force-pushed the Himself65:27639 branch from 356beac to a1536b4 May 24, 2019

lib/child_process.js Outdated Show resolved Hide resolved

@Himself65 Himself65 force-pushed the Himself65:27639 branch 2 times, most recently from fe39082 to 897ca32 May 24, 2019

@targos
targos approved these changes May 25, 2019

@targos targos removed the semver-major label May 25, 2019

@nodejs-github-bot

This comment has been minimized.

@Himself65 Himself65 force-pushed the Himself65:27639 branch 2 times, most recently from be8b3cb to 6780a11 May 25, 2019

@BridgeAR

This comment has been minimized.

Copy link
Member

commented May 29, 2019

@Himself65 it seems like this needs a rebase :)

@Himself65 Himself65 force-pushed the Himself65:27639 branch from 6780a11 to 843478e May 29, 2019

@Himself65 Himself65 force-pushed the Himself65:27639 branch from 843478e to cfbb5bb May 29, 2019

@Himself65

This comment has been minimized.

Copy link
Contributor Author

commented May 29, 2019

@BridgeAR thanks. rebased

@Trott
Trott approved these changes May 30, 2019
@nodejs-github-bot

This comment was marked as outdated.

@ZYSzys
ZYSzys approved these changes May 30, 2019
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment has been minimized.

@Trott

This comment has been minimized.

Copy link
Member

commented Jun 2, 2019

Landed in aa00968

@Trott Trott closed this Jun 2, 2019

Trott added a commit to Trott/io.js that referenced this pull request Jun 2, 2019
child_process: move exports to bottom for consistent code style
PR-URL: nodejs#27845
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>

@Himself65 Himself65 deleted the Himself65:27639 branch Jun 2, 2019

targos added a commit that referenced this pull request Jun 3, 2019
child_process: move exports to bottom for consistent code style
PR-URL: #27845
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@targos targos referenced this pull request Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.