Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fs - remove encoding list and link to buffer #2796

Conversation

Projects
None yet
8 participants
@claudiorodriguez
Copy link
Member

commented Sep 10, 2015

Removes the accepted encoding lists from fs.createReadStream and fs.createWriteStream, linking instead to Buffer which has a list of accepted encodings. Would solve #2787

@Fishrock123 Fishrock123 added the doc label Sep 10, 2015

@Fishrock123

This comment has been minimized.

Copy link
Member

commented Sep 10, 2015

SGTM

@mscdex mscdex added the fs label Sep 10, 2015

@trevnorris

This comment has been minimized.

Copy link
Contributor

commented Sep 23, 2015

LGTM

@silverwind

This comment has been minimized.

Copy link
Contributor

commented Oct 9, 2015

@fansworld-claudio can you link to buffer.html#buffer_buffer? That anchor is closer to the list of encodings. Maybe also use a shared anchor (see the bottom of many markdown files) for both links.

@claudiorodriguez

This comment has been minimized.

Copy link
Member Author

commented Oct 13, 2015

@silverwind Good idea, change pushed.

@jasnell

This comment has been minimized.

Copy link
Member

commented Nov 5, 2015

@silverwind .. since you had the last comment to be address can you PTAL.
meanwhile, LGTM

@silverwind

This comment has been minimized.

Copy link
Contributor

commented Nov 5, 2015

LGTM

jasnell added a commit that referenced this pull request Nov 5, 2015

docs: fs - change links to buffer encoding to Buffer class anchor
PR-URL: #2796
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

This comment has been minimized.

Copy link
Member

commented Nov 5, 2015

Landed in 30ce3eb

@jasnell jasnell closed this Nov 5, 2015

rvagg added a commit that referenced this pull request Nov 7, 2015

docs: fs - change links to buffer encoding to Buffer class anchor
PR-URL: #2796
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>

@Fishrock123 Fishrock123 referenced this pull request Nov 11, 2015

Merged

Propose v5.1.0 #3736

@MylesBorins

This comment has been minimized.

Copy link
Member

commented Nov 16, 2015

landed in lts-v4.x-staging as 5689630

MylesBorins added a commit that referenced this pull request Nov 16, 2015

docs: fs - change links to buffer encoding to Buffer class anchor
PR-URL: #2796
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>

@rvagg rvagg referenced this pull request Nov 17, 2015

Closed

v4.2.2+1 commit candidates #57

rvagg added a commit that referenced this pull request Dec 4, 2015

docs: fs - change links to buffer encoding to Buffer class anchor
PR-URL: #2796
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>

@jasnell jasnell referenced this pull request Dec 17, 2015

Closed

Release 4.2.4 Planning #4321

jasnell added a commit that referenced this pull request Dec 17, 2015

docs: fs - change links to buffer encoding to Buffer class anchor
PR-URL: #2796
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell added a commit that referenced this pull request Dec 23, 2015

docs: fs - change links to buffer encoding to Buffer class anchor
PR-URL: #2796
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
@rvagg

This comment has been minimized.

Copy link
Member

commented Jan 15, 2016

@thealphanerd you only landed one of these commits, the other, 87c6c77, is not on v4.x but it doesn't land cleanly.

I'd suggest either leaving that one off v4.x or, @fansworld-claudio if you'd like to submit a PR for that commit against v4.x-staging then we can land it.

@jasnell

This comment has been minimized.

Copy link
Member

commented Jan 15, 2016

@rvagg ... if I recall correctly, the commit that actually landed in master was squashed into a single commit (5689630). It looks like @thealphanerd picked that commit into v4.x-staging which is why the second commit here doesn't appear and doesn't land clean. (I could be wrong tho)

@rvagg

This comment has been minimized.

Copy link
Member

commented Jan 16, 2016

$ git log master --format='%h %an: %s' | grep fansworld-claudio
2a29b70 fansworld-claudio: doc: url.format - true slash postfix behaviour
9a628e2 fansworld-claudio: test: module loading error fix solaris #3798
30ce3eb fansworld-claudio: docs: fs - change links to buffer encoding to Buffer class anchor
2e38079 fansworld-claudio: docs: fs - remove encoding list and link to buffer
49f965c fansworld-claudio: docs: add missing shell option to execSync

30ce3eb and 2e38079

They show up in branch-diff, when comparing v4.x-staging to master:

  • [2e38079ea4] - docs: fs - remove encoding list and link to buffer (fansworld-claudio)

And v4.x-staging to v5.x:

  • [7a84fa6c60] - docs: fs - remove encoding list and link to buffer (fansworld-claudio)
@MylesBorins

This comment has been minimized.

Copy link
Member

commented Mar 17, 2016

@rvagg looks like we are now stuck with 7a84fa6 forever showing up as a false positive when doing audits... perhaps there is a way to add meta data to the comments inside the commit that branch-diff / changelog maker can use?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.