Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix configure script to work with Apple Clang 11 #28071

Merged
merged 1 commit into from Jun 12, 2019
Merged

Conversation

@saagarjha
Copy link
Contributor

saagarjha commented Jun 5, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Xcode 11's clang doesn't match our regex:

$ clang --version
Apple clang version 11.0.0 (clang-1100.0.20.17)
Target: x86_64-apple-darwin19.0.0
Thread model: posix
InstalledDir: /Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

I've updated the regex in the configure script so that it will try to match the newer one if the old one fails.

Copy link
Member

bnoordhuis left a comment

LGTM with a suggestion.

configure.py Outdated Show resolved Hide resolved
@saagarjha saagarjha force-pushed the saagarjha:master branch from 0a8dfca to 2726ece Jun 5, 2019
@lpinca
lpinca approved these changes Jun 5, 2019
@nodejs-github-bot

This comment has been minimized.

@lpinca

This comment has been minimized.

Copy link
Member

lpinca commented Jun 11, 2019

@saagarjha can you please fix the commit title?

build: fix configure script to work with Apple Clang 11
@saagarjha saagarjha force-pushed the saagarjha:master branch from 2726ece to 4de3a06 Jun 11, 2019
@saagarjha

This comment has been minimized.

Copy link
Contributor Author

saagarjha commented Jun 11, 2019

Fixed, thanks.

@refack
refack approved these changes Jun 12, 2019
Copy link
Member

refack left a comment

RSLGTM

PR-URL: #28071
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
@refack refack force-pushed the saagarjha:master branch from 4de3a06 to 1f143b8 Jun 12, 2019
@refack refack added the Python label Jun 12, 2019
@refack refack merged commit 1f143b8 into nodejs:master Jun 12, 2019
1 of 2 checks passed
1 of 2 checks passed
Travis CI - Pull Request Build Errored
Details
Travis CI - Branch Build Passed
Details
BridgeAR added a commit that referenced this pull request Jun 17, 2019
PR-URL: #28071
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Jun 17, 2019
@AshCripps

This comment has been minimized.

Copy link
Member

AshCripps commented Nov 12, 2019

I suggest this gets backported to v10.x as without this change im unable to build v10 on catalina with current xcode versions.

@BethGriggs @nodejs/lts

@sam-github

This comment has been minimized.

Copy link
Member

sam-github commented Nov 12, 2019

@nodejs/lts Doesn't affect our CI, but catalina users won't be able to build v10.x without it.

Picks clean onto v10.x-staging.

BethGriggs added a commit that referenced this pull request Nov 19, 2019
PR-URL: #28071
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 4, 2019
MylesBorins added a commit that referenced this pull request Dec 17, 2019
PR-URL: #28071
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.