Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for Http2Stream#id property #28074

Closed

Conversation

Projects
None yet
8 participants
@murgatroid99
Copy link
Contributor

commented Jun 5, 2019

Checklist
  • documentation is changed or added

This property is already mentioned in this section of the documentation. The implementation can be found here, and it was introduced in the original commit for the http2 module

@cjihrig

cjihrig approved these changes Jun 5, 2019

@lpinca

lpinca approved these changes Jun 5, 2019

Show resolved Hide resolved doc/api/http2.md Outdated
Use code markup for the word undefined
Co-Authored-By: Luigi Pinca <luigipinca@gmail.com>
@trivikr

trivikr approved these changes Jun 5, 2019

Show resolved Hide resolved doc/api/http2.md Outdated
Explicitly include undefined in type specifier
Co-Authored-By: Rich Trott <rtrott@gmail.com>
@Trott

Trott approved these changes Jun 7, 2019

@trivikr

trivikr approved these changes Jun 7, 2019

@Trott

This comment has been minimized.

@Trott Trott added the author ready label Jun 10, 2019

@cjihrig

This comment has been minimized.

Copy link
Contributor

commented Jun 11, 2019

Landed in 155caf7. Thanks!

@cjihrig cjihrig closed this Jun 11, 2019

cjihrig added a commit that referenced this pull request Jun 11, 2019

doc: document Http2Stream#id property
PR-URL: #28074
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

BridgeAR added a commit that referenced this pull request Jun 17, 2019

doc: document Http2Stream#id property
PR-URL: #28074
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@BridgeAR BridgeAR referenced this pull request Jun 17, 2019

Merged

v12.5.0 proposal #28268

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.