Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs: document the Date conversion in Stats objects #28224

Closed
wants to merge 2 commits into from

Conversation

@joyeecheung
Copy link
Member

commented Jun 14, 2019

Document why the dates are calculated with the timestamp
in Numbers + 0.5.

The comment was previously lost in a revert.

Refs: ae6c704

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
fs: document the Date conversion in Stats objects
Document why the dates are calculated with the timestamp
in Numbers + 0.5.

The comment was previously lost in a revert.

Refs: ae6c704
@nodejs-github-bot

This comment has been minimized.

Copy link

commented Jun 14, 2019

Sadly, an error occurred when I tried to trigger a build. :(
CI: https://ci.nodejs.org/job/node-test-pull-request/23877/

@joyeecheung

This comment has been minimized.

Copy link
Member Author

commented Jun 16, 2019

@nodejs-github-bot

This comment has been minimized.

@joyeecheung

This comment has been minimized.

Copy link
Member Author

commented Jun 17, 2019

cc'ing people who reverted the original commit @addaleax @TimothyGu @refack @cjihrig

@nodejs-github-bot

This comment has been minimized.

lib/internal/fs/utils.js Outdated Show resolved Hide resolved
@Trott
Trott approved these changes Jun 17, 2019
Copy link
Member

left a comment

LGTM with or without small typo in comment fixed.

@nodejs-github-bot

This comment has been minimized.

BridgeAR added a commit to BridgeAR/node that referenced this pull request Jun 17, 2019
fs: document the Date conversion in Stats objects
Document why the dates are calculated with the timestamp
in Numbers + 0.5.

The comment was previously lost in a revert.

Refs: nodejs@ae6c704

PR-URL: nodejs#28224
Refs: nodejs@ae6c704
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR

This comment has been minimized.

Copy link
Member

commented Jun 17, 2019

Landed in b6326ce 🎉

@BridgeAR BridgeAR closed this Jun 17, 2019

BridgeAR added a commit that referenced this pull request Jun 17, 2019
fs: document the Date conversion in Stats objects
Document why the dates are calculated with the timestamp
in Numbers + 0.5.

The comment was previously lost in a revert.

Refs: ae6c704

PR-URL: #28224
Refs: ae6c704
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR BridgeAR referenced this pull request Jun 17, 2019
BridgeAR added a commit that referenced this pull request Sep 3, 2019
fs: document the Date conversion in Stats objects
Document why the dates are calculated with the timestamp
in Numbers + 0.5.

The comment was previously lost in a revert.

Refs: ae6c704

PR-URL: #28224
Refs: ae6c704
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR BridgeAR referenced this pull request Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.