Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: remove instructions to post CI links #28248

Merged
merged 0 commits into from Jun 18, 2019

Conversation

@Trott
Copy link
Member

commented Jun 16, 2019

Remove instructions (in the Collaborator Guide) to post CI links. The
bot does that now.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@Trott Trott added the doc label Jun 16, 2019

@nodejs-github-bot

This comment was marked as outdated.

Copy link

commented Jun 16, 2019

Sadly, an error occurred when I tried to trigger a build. :(

@Trott

This comment has been minimized.

Copy link
Member Author

commented Jun 16, 2019

@Trott Trott added the author ready label Jun 17, 2019

@Trott

This comment has been minimized.

Copy link
Member Author

commented Jun 18, 2019

Landed in 8030ca5

@Trott Trott closed this Jun 18, 2019

@Trott Trott force-pushed the Trott:post-a-ci branch from 51784d0 to 8030ca5 Jun 18, 2019

@Trott Trott deleted the Trott:post-a-ci branch Jun 18, 2019

@Trott Trott merged commit 8030ca5 into nodejs:master Jun 18, 2019

1 check passed

Travis CI - Branch Build Passed
Details
targos added a commit that referenced this pull request Jul 2, 2019
doc: remove instructions to post CI links
Remove instructions (in the Collaborator Guide) to post CI links. The
bot does that now.

PR-URL: #28248
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targos targos referenced this pull request Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.