Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add Worker + uncaughtException + process.exit() test #28259

Closed
wants to merge 2 commits into from

Conversation

@addaleax
Copy link
Member

commented Jun 17, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
@nodejs-github-bot

This comment has been minimized.

Copy link

commented Jun 17, 2019

Sadly, an error occurred when I tried to trigger a build. :(

@addaleax addaleax referenced this pull request Jun 17, 2019
2 of 2 tasks complete
@Trott
Copy link
Member

left a comment

This test will fail if run with the tools/test.py --worker.

@joyeecheung

This comment has been minimized.

Copy link
Member

commented Jun 17, 2019

Maybe put the worker code in a fixture instead? So it won't get run by --worker. Or just eval the code.

@addaleax

This comment has been minimized.

Copy link
Member Author

commented Jun 17, 2019

@joyeecheung @Trott I’ve updated this with the standard approach we use in our tests (using an env var instead of isMainThread)

@nodejs-github-bot

This comment has been minimized.

@Trott
Trott approved these changes Jun 17, 2019
@addaleax

This comment has been minimized.

Copy link
Member Author

commented Jun 19, 2019

Landed in 7146ddd

@addaleax addaleax closed this Jun 19, 2019

@addaleax addaleax deleted the addaleax:worker-uncaught-exception branch Jun 19, 2019

pull bot pushed a commit to Rachelmorrell/node that referenced this pull request Jun 19, 2019
test: add Worker + uncaughtException + process.exit() test
PR-URL: nodejs#28259
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
targos added a commit that referenced this pull request Jul 2, 2019
test: add Worker + uncaughtException + process.exit() test
PR-URL: #28259
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@targos targos referenced this pull request Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.