Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update babel-eslint to 10.0.2 #28266

Closed
wants to merge 1 commit into from

Conversation

@ZYSzys
Copy link
Member

commented Jun 17, 2019

Update babel-eslint to 10.0.2 by running tools/update-babel-eslint.sh.

Refs: https://github.com/babel/babel-eslint/releases/tag/v10.0.2

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@ZYSzys

This comment has been minimized.

Copy link
Member Author

commented Jun 17, 2019

@BridgeAR
Copy link
Member

left a comment

RSLGTM

This seems to add a few files that were missing before 👍 (even though it seems like we did not require them).

@trivikr
Copy link
Member

left a comment

RSLGTM

@Trott
Trott approved these changes Jun 19, 2019
Copy link
Member

left a comment

Rubber-stamp LGTM

@Trott
Trott approved these changes Jun 19, 2019
Copy link
Member

left a comment

Non-rubber-stamp LGTM. The change set is manageable so I was able to actually review it. :-D

@ZYSzys

This comment has been minimized.

Copy link
Member Author

commented Jun 20, 2019

Landed in d698983.

@ZYSzys ZYSzys closed this Jun 20, 2019

ZYSzys added a commit to zys-contribs/node that referenced this pull request Jun 20, 2019
tools: update babel-eslint to 10.0.2
PR-URL: nodejs#28266
Refs: https://github.com/babel/babel-eslint/releases/tag/v10.0.2
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

@ZYSzys ZYSzys deleted the zys-contribs:babel-eslint branch Jun 20, 2019

targos added a commit that referenced this pull request Jul 2, 2019
tools: update babel-eslint to 10.0.2
PR-URL: #28266
Refs: https://github.com/babel/babel-eslint/releases/tag/v10.0.2
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@targos targos referenced this pull request Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.