Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: revise strict mode text in assert #28285

Merged
merged 1 commit into from Jun 21, 2019

Conversation

@Trott
Copy link
Member

commented Jun 19, 2019

Revise the text describing strict mode.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@Trott Trott force-pushed the Trott:revise-strict-mode-yo branch from f96e5f4 to cfbd5f5 Jun 19, 2019

@Trott

This comment has been minimized.

Copy link
Member Author

commented Jun 19, 2019

@Trott Trott added the author ready label Jun 19, 2019

doc: revise strict mode text in assert
Revise the text describing `strict` mode.

PR-URL: #28285
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

@Trott Trott force-pushed the Trott:revise-strict-mode-yo branch from cfbd5f5 to 3af27f8 Jun 21, 2019

@Trott

This comment has been minimized.

Copy link
Member Author

commented Jun 21, 2019

Landed in 3af27f8

@Trott Trott merged commit 3af27f8 into nodejs:master Jun 21, 2019

1 check passed

Travis CI - Branch Build Passed
Details
targos added a commit that referenced this pull request Jul 2, 2019
doc: revise strict mode text in assert
Revise the text describing `strict` mode.

PR-URL: #28285
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targos targos referenced this pull request Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.