Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix flaky test-worker-debug #28307

Closed
wants to merge 1 commit into from

Conversation

@addaleax
Copy link
Member

commented Jun 19, 2019

Address a race condition in the test; the Worker’s exit events
may have been not recorded because the Worker exited before
the listeners were attached.

Fix the by attaching the event listeners before telling the Worker
to exit.

Fixes: #28299
Fixes: #28106

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
test: fix flaky test-worker-debug
Address a race condition in the test; the Worker’s exit events
may have been not recorded because the Worker exited before
the listeners were attached.

Fix the by attaching the event listeners before telling the Worker
to exit.

Fixes: #28299
Fixes: #28106
@nodejs-github-bot

This comment has been minimized.

@addaleax

This comment has been minimized.

Copy link
Member Author

commented Jun 19, 2019

Stress test: https://ci.nodejs.org/job/node-stress-single-test/2232/
Stress test: https://ci.nodejs.org/job/node-stress-single-test/2233/

Please 👍 this comment to approve fast-tracking.

@addaleax addaleax referenced this pull request Jun 19, 2019
0 of 4 tasks complete
@ZYSzys
ZYSzys approved these changes Jun 20, 2019
@danbev

This comment has been minimized.

Copy link
Member

commented Jun 20, 2019

Landed in 2dec0f9.

@danbev danbev closed this Jun 20, 2019

danbev added a commit that referenced this pull request Jun 20, 2019
test: fix flaky test-worker-debug
Address a race condition in the test; the Worker’s exit events
may have been not recorded because the Worker exited before
the listeners were attached.

Fix the by attaching the event listeners before telling the Worker
to exit.

PR-URL: #28307
Fixes: #28299
Fixes: #28106
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>

@addaleax addaleax deleted the addaleax:test-worker-debug-fix branch Jun 20, 2019

targos added a commit that referenced this pull request Jul 2, 2019
test: fix flaky test-worker-debug
Address a race condition in the test; the Worker’s exit events
may have been not recorded because the Worker exited before
the listeners were attached.

Fix the by attaching the event listeners before telling the Worker
to exit.

PR-URL: #28307
Fixes: #28299
Fixes: #28106
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@targos targos referenced this pull request Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.