Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: switch the param order in the assertion #28341

Conversation

@raveneyex
Copy link
Contributor

commented Jun 21, 2019

Switch the param order in the assertion at line 140
so that they are in the correct order (actual, expected)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
test: switch the param order in the assertion
Switch the param order in the assertion at line 140
so that they are in the correct order (actual, expected)
@Trott
Trott approved these changes Jun 21, 2019
@ZYSzys
ZYSzys approved these changes Jun 22, 2019
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@ZYSzys

This comment has been minimized.

Copy link
Member

commented Jun 26, 2019

Landed in 2341693

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

@ZYSzys ZYSzys closed this Jun 26, 2019

pull bot pushed a commit to tkamenoko/node that referenced this pull request Jun 26, 2019
test: switch the param order in the assertion
Switch the param order in the assertion at line 140
so that they are in the correct order (actual, expected)

PR-URL: nodejs#28341
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos added a commit that referenced this pull request Jul 2, 2019
test: switch the param order in the assertion
Switch the param order in the assertion at line 140
so that they are in the correct order (actual, expected)

PR-URL: #28341
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos referenced this pull request Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.