Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix order of assertion arguments in test-buffer-indexof #28359

Closed
wants to merge 3 commits into from

Conversation

@MistyBlunch
Copy link
Contributor

commented Jun 21, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@Trott
Copy link
Member

left a comment

Welcome @MistyBlunch and thanks for the pull request! There appears to be an unrelated change in this pull request that should be removed. Additionally, the commit message can be improved. Perhaps this?: test: fix order of assertion arguments in test-buffer-indexof Hope this help!

tools/macos-firewall.sh Outdated Show resolved Hide resolved

@MistyBlunch MistyBlunch changed the title test: change order of arguments test: fix order of assertion arguments in test-buffer-indexof Jun 21, 2019

MistyBlunch added 2 commits Jun 21, 2019
@Trott
Trott approved these changes Jun 22, 2019
@nodejs-github-bot

This comment has been minimized.

@addaleax

This comment has been minimized.

Copy link
Member

commented Jun 25, 2019

Landed in 6966e15

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

@addaleax addaleax closed this Jun 25, 2019

pull bot pushed a commit to Pandinosaurus/node that referenced this pull request Jun 25, 2019
test: change order of arguments
PR-URL: nodejs#28359
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
jshricarde added a commit to jshricarde/node that referenced this pull request Jun 25, 2019
test: change order of arguments
PR-URL: nodejs#28359
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos added a commit that referenced this pull request Jul 2, 2019
test: change order of arguments
PR-URL: #28359
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos referenced this pull request Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.