Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vm: increase code coverage of source_text_module.js #28363

Closed

Conversation

@kball
Copy link
Contributor

commented Jun 21, 2019

1 more line of code coverage: https://coverage.nodejs.org/coverage-1a4f27ae21698d0c/lib/internal/vm/source_text_module.js.html#L161

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
@Trott
Trott approved these changes Jun 23, 2019

@Trott Trott added the author ready label Jun 23, 2019

@nodejs-github-bot

This comment has been minimized.

@addaleax

This comment has been minimized.

Copy link
Member

commented Jun 25, 2019

Landed in 6c2f78e

Thanks for the contribution, and welcome to the project! 🎉

@addaleax addaleax closed this Jun 25, 2019

addaleax added a commit that referenced this pull request Jun 25, 2019
vm: increase code coverage of source_text_module.js
PR-URL: #28363
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jshricarde added a commit to jshricarde/node that referenced this pull request Jun 25, 2019
vm: increase code coverage of source_text_module.js
PR-URL: nodejs#28363
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos added a commit that referenced this pull request Jul 2, 2019
vm: increase code coverage of source_text_module.js
PR-URL: #28363
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos referenced this pull request Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.