Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add example of event close for child_process #28376

Closed
wants to merge 2 commits into from

Conversation

@ltciro
Copy link
Contributor

commented Jun 21, 2019

add a missing example of the event close for child_process

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
```js
const { spawn } = require('child_process');
const ls = spawn('ls', ['-lh', '/usr']);

This comment has been minimized.

Copy link
@jasnell

jasnell Jun 23, 2019

Member

One suggestion for the example :-)

Suggested change
ls.stdout.setEncoding('utf8');
@Trott

This comment has been minimized.

Copy link
Member

commented Jun 24, 2019

@nodejs/documentation This duplicates sample code from elsewhere in the doc. Is this how we want to do this sort of thing? Would a more succinct example which focuses on close be a better fit here?

@Trott

This comment has been minimized.

@Trott
Trott approved these changes Jul 30, 2019

@Trott Trott added the author ready label Jul 30, 2019

@Trott

This comment has been minimized.

Copy link
Member

commented Jul 30, 2019

@nodejs-github-bot

This comment has been minimized.

@Trott

This comment has been minimized.

Copy link
Member

commented Jul 30, 2019

Landed in 89344f5

@Trott Trott closed this Jul 30, 2019

Trott added a commit to Trott/io.js that referenced this pull request Jul 30, 2019
doc: add example of event close for child_process
PR-URL: nodejs#28376
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos added a commit that referenced this pull request Aug 2, 2019
doc: add example of event close for child_process
PR-URL: #28376
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BridgeAR BridgeAR referenced this pull request Aug 6, 2019
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
doc: add example of event close for child_process
PR-URL: nodejs#28376
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
doc: add example of event close for child_process
PR-URL: nodejs#28376
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.