Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix nits regarding stream utilities #28385

Closed

Conversation

@vsemozhetbyt
Copy link
Contributor

commented Jun 22, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
  • Unify headings.
  • Conform method mentions with the style guide.
  • Fix links.

### Readable.from() -> ### stream.Readable.from() heading change seems suboptimal and non-typical, but it seems it would be wrong to place this part with descriptions of Readable instances or to leave it as is along with other stream.* utilities, in incorrect structure and sorting place.

doc: fix nits regarding stream utilities
* Unify headings.
* Conform method mentions with the style guide.
* Fix links.

@vsemozhetbyt vsemozhetbyt force-pushed the vsemozhetbyt:doc-stream-util-nits branch from 6a34037 to 478b2f7 Jun 22, 2019

@Trott
Trott approved these changes Jun 22, 2019
@ZYSzys
ZYSzys approved these changes Jun 22, 2019
@lpinca
lpinca approved these changes Jun 22, 2019

@Trott Trott added the author ready label Jun 24, 2019

@Trott

This comment has been minimized.

Copy link
Member

commented Jun 24, 2019

@addaleax

This comment has been minimized.

Copy link
Member

commented Jun 25, 2019

Landed in daa512b

@addaleax addaleax closed this Jun 25, 2019

addaleax added a commit that referenced this pull request Jun 25, 2019
doc: fix nits regarding stream utilities
* Unify headings.
* Conform method mentions with the style guide.
* Fix links.

PR-URL: #28385
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@vsemozhetbyt vsemozhetbyt deleted the vsemozhetbyt:doc-stream-util-nits branch Jun 25, 2019

jshricarde added a commit to jshricarde/node that referenced this pull request Jun 25, 2019
doc: fix nits regarding stream utilities
* Unify headings.
* Conform method mentions with the style guide.
* Fix links.

PR-URL: nodejs#28385
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos added a commit that referenced this pull request Jul 2, 2019
doc: fix nits regarding stream utilities
* Unify headings.
* Conform method mentions with the style guide.
* Fix links.

PR-URL: #28385
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos referenced this pull request Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
10 participants
You can’t perform that action at this time.