Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: cleanup pendingSettingsAck docs #28388

Merged
merged 1 commit into from Jun 25, 2019

Conversation

@cjihrig
Copy link
Contributor

commented Jun 22, 2019

This commit rephrases the first sentence of the http2 session pendingSettingsAck property docs. It also formats SETTINGS consistently.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
@lpinca
lpinca approved these changes Jun 22, 2019
@cjihrig

This comment has been minimized.

Copy link
Contributor Author

commented Jun 24, 2019

Indicates whether or not the `Http2Session` is currently waiting for an
acknowledgment for a sent `SETTINGS` frame. Will be `true` after calling the
`http2session.settings()` method. Will be `false` once all sent SETTINGS
Indicates whether or not the `Http2Session` is currently waiting for

This comment has been minimized.

Copy link
@Trott

Trott Jun 24, 2019

Member

Totally optional micro-suggestion:

Suggested change
Indicates whether or not the `Http2Session` is currently waiting for
Indicates whether the `Http2Session` is currently waiting for
@Trott
Trott approved these changes Jun 24, 2019
doc: cleanup pendingSettingsAck docs
This commit rephrases the first sentence of the http2 session
pendingSettingsAck property docs. It also formats SETTINGS
consistently.

PR-URL: #28388
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

@cjihrig cjihrig force-pushed the cjihrig:pending branch from 06ba5d9 to a7e0155 Jun 25, 2019

@cjihrig cjihrig merged commit a7e0155 into nodejs:master Jun 25, 2019

1 of 3 checks passed

Travis CI - Pull Request Build Errored
Details
Travis CI - Pull Request Build Created
Details
Travis CI - Branch Build Passed
Details

@cjihrig cjihrig deleted the cjihrig:pending branch Jun 25, 2019

jshricarde added a commit to jshricarde/node that referenced this pull request Jun 25, 2019
doc: cleanup pendingSettingsAck docs
This commit rephrases the first sentence of the http2 session
pendingSettingsAck property docs. It also formats SETTINGS
consistently.

PR-URL: nodejs#28388
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos added a commit that referenced this pull request Jul 2, 2019
doc: cleanup pendingSettingsAck docs
This commit rephrases the first sentence of the http2 session
pendingSettingsAck property docs. It also formats SETTINGS
consistently.

PR-URL: #28388
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos referenced this pull request Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.