Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update remark-preset-lint-node to 1.7.0 #28393

Merged
merged 0 commits into from Jun 27, 2019

Conversation

@Trott
Copy link
Member

commented Jun 23, 2019

This update enables linting for "note that" in our docs. That phrase is
almost always superfluous. Sentences are almost always clearer and
stronger without it.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@Trott

This comment has been minimized.

Copy link
Member Author

commented Jun 23, 2019

@Trott

This comment has been minimized.

Copy link
Member Author

commented Jun 26, 2019

@Trott Trott added the author ready label Jun 26, 2019

@Trott

This comment has been minimized.

Copy link
Member Author

commented Jun 26, 2019

A note on landing this, in case someone other than me does it: Be sure to run make lint-md before pushing the commit to upstream. It's possible that some violations of the newly-added lint constraint have been committed since this was opened. Probably not, but if so, those will need to be fixed while landing this.

@Trott Trott closed this Jun 27, 2019

@Trott Trott force-pushed the Trott:update-note-that branch from 63e3d80 to cf9a7f2 Jun 27, 2019

@Trott Trott deleted the Trott:update-note-that branch Jun 27, 2019

@Trott

This comment has been minimized.

Copy link
Member Author

commented Jun 27, 2019

Landed in cf9a7f2

@Trott Trott merged commit cf9a7f2 into nodejs:master Jun 27, 2019

1 check passed

Travis CI - Branch Build Passed
Details
targos added a commit that referenced this pull request Jul 2, 2019
tools: update remark-preset-lint-node to 1.7.0
This update enables linting for "note that" in our docs. That phrase is
almost always superfluous. Sentences are almost always clearer and
stronger without it.

PR-URL: #28393
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
@targos targos referenced this pull request Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.