Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

worker: assign missing deprecation code #28395

Closed

Conversation

@jasnell
Copy link
Member

commented Jun 23, 2019

Deprecation code was not assigned.

@nodejs/tooling ... might be worthwhile adding a check for DEP00XX and DEP0XXX in the change using git-node-land

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@jasnell jasnell added deprecations and removed worker labels Jun 23, 2019

@Trott
Trott approved these changes Jun 24, 2019
@ZYSzys
ZYSzys approved these changes Jun 24, 2019
@nodejs-github-bot

This comment has been minimized.

@lpinca
lpinca approved these changes Jun 24, 2019
@addaleax

This comment has been minimized.

Copy link
Member

commented Jul 3, 2019

Landed in f5f8a18

@addaleax addaleax closed this Jul 3, 2019

@addaleax addaleax added the worker label Jul 3, 2019

addaleax added a commit that referenced this pull request Jul 3, 2019
worker: assign missing deprecation code
PR-URL: #28395
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
targos added a commit that referenced this pull request Jul 20, 2019
worker: assign missing deprecation code
PR-URL: #28395
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
This was referenced Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.