Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation line for host:port invocation #28405

Closed
Closed
Changes from 3 commits
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

@@ -164,7 +164,7 @@ function print(stream) {
options.set('--', { helpText: 'indicate the end of node options' });
stream.write(
'Usage: node [options] [ -e script | script.js | - ] [arguments]\n' +
' node inspect script.js [arguments]\n\n' +
' node inspect [script.js | -e "script" | <host>:<port>] …\n\n' +

This comment has been minimized.

Copy link
@Trott

Trott Jun 25, 2019

Member

This uses an ellipsis character () where everywhere else, we use three dots (...). On the one hand, the ellipsis is more correct. On the other hand, is there a situation where it will be an unprintable character because the terminal only accepts ASCII? Regardless, the code should probably pick one or the other and stick with it.

This comment has been minimized.

Copy link
@Trott

Trott Jul 6, 2019

Member

Linter requires non-ASCII characters (to keep binary size down, believe it or not) so ... it must be.

Also, this should probably align with line 166 in that no " around script and -e comes before the script.js option.

Assuming you left the default checked state for the checkbox about allowing collaborators in this repo to push to your branch, I'll make these updates right now....

'Options:\n');
stream.write(indent(format({
options, aliases, firstColumn, secondColumn
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.