Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify response.finished #28411

Closed
wants to merge 1 commit into from

Conversation

@ronag
Copy link
Contributor

commented Jun 24, 2019

This fixes some regular confusion in regards to the response.finished property and makes it more consistent with the description for request.finished.

Refs: jshttp/on-finished#30

Checklist
@Trott
Trott approved these changes Jun 25, 2019
doc/api/http.md Outdated Show resolved Hide resolved

@ronag ronag force-pushed the nxtedition:fix-finished-docs branch from 4797264 to 6ecd5a8 Jun 25, 2019

@lpinca
lpinca approved these changes Jun 26, 2019

@ronag ronag force-pushed the nxtedition:fix-finished-docs branch from 6ecd5a8 to 0999d49 Jun 26, 2019

@Trott

This comment has been minimized.

@Trott Trott added the author ready label Jun 27, 2019

@Trott

This comment has been minimized.

Copy link
Member

commented Jun 27, 2019

Landed in 63a0f4c

Trott added a commit to Trott/io.js that referenced this pull request Jun 27, 2019
doc: clarify response.finished
PR-URL: nodejs#28411
Refs: jshttp/on-finished#30
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

@Trott Trott closed this Jun 27, 2019

targos added a commit that referenced this pull request Jul 2, 2019
doc: clarify response.finished
PR-URL: #28411
Refs: jshttp/on-finished#30
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targos targos referenced this pull request Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.