Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: fix typo in js2c.py #28417

Closed
wants to merge 1 commit into from

Conversation

@danbev
Copy link
Member

commented Jun 25, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@danbev

This comment has been minimized.

@targos
targos approved these changes Jun 25, 2019
@trivikr

This comment has been minimized.

Copy link
Member

commented Jun 25, 2019

This is a typo fix in comments, and I believe it can be approved for fast-track
Feel free to 👍 this comment to approve fast-tracking

@trivikr trivikr added the fast-track label Jun 25, 2019

@Trott
Trott approved these changes Jun 25, 2019
@lpinca
lpinca approved these changes Jun 26, 2019
@danbev

This comment has been minimized.

Copy link
Member Author

commented Jun 28, 2019

Landed in fcf2da0.

@danbev danbev closed this Jun 28, 2019

pull bot pushed a commit to tkamenoko/node that referenced this pull request Jun 28, 2019
tools: fix typo in js2c.py
PR-URL: nodejs#28417
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos added a commit that referenced this pull request Jul 2, 2019
tools: fix typo in js2c.py
PR-URL: #28417
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos added a commit that referenced this pull request Jul 2, 2019
tools: fix typo in js2c.py
PR-URL: #28417
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos referenced this pull request Jul 2, 2019

@danbev danbev deleted the danbev:js2c-typo branch Aug 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.