Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: fix typo in cache_builder.cc #28418

Closed
wants to merge 1 commit into from

Conversation

@danbev
Copy link
Member

commented Jun 25, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@danbev

This comment has been minimized.

Copy link
Member Author

commented Jun 25, 2019

@targos
targos approved these changes Jun 25, 2019
@ZYSzys
ZYSzys approved these changes Jun 25, 2019
@addaleax

This comment has been minimized.

Copy link
Member

commented Jun 25, 2019

I guess technically this also needs to be approved for fast-tracking? In any case, feel free to 👍 this comment (to approve that).

@addaleax addaleax added the fast-track label Jun 25, 2019

@Trott
Trott approved these changes Jun 25, 2019
@danbev

This comment has been minimized.

Copy link
Member Author

commented Jun 26, 2019

Landed in 3322686.

@danbev danbev closed this Jun 26, 2019

@danbev danbev deleted the danbev:tools_cache_builder_typo branch Jun 26, 2019

danbev added a commit that referenced this pull request Jun 26, 2019
tools: fix typo in cache_builder.cc
PR-URL: #28418
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos added a commit that referenced this pull request Jul 2, 2019
tools: fix typo in cache_builder.cc
PR-URL: #28418
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos referenced this pull request Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.