Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: cleanup isDead() example #28421

Merged
merged 1 commit into from Jun 27, 2019

Conversation

@cjihrig
Copy link
Contributor

commented Jun 25, 2019

This commit removes extra whitespace and some awkward text containing typos from the cluster worker.isDead() code sample.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
@Trott
Trott approved these changes Jun 25, 2019
@Trott

This comment has been minimized.

Copy link
Member

commented Jun 25, 2019

Super micro-nit: s/cleanup/clean up/ in commit message?

@trivikr

This comment has been minimized.

Copy link
Member

commented Jun 25, 2019

Feel free to 👍 this comment to approve fast-tracking

@lpinca
lpinca approved these changes Jun 25, 2019

@trivikr trivikr added the fast-track label Jun 25, 2019

@cjihrig

This comment has been minimized.

Copy link
Contributor Author

commented Jun 26, 2019

doc: clean up isDead() example
This commit removes extra whitespace and some awkward text
containing typos from the cluster worker.isDead() code
sample.

PR-URL: #28421
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@cjihrig cjihrig force-pushed the cjihrig:cluster branch from 674bb10 to 63a5cd8 Jun 27, 2019

@cjihrig cjihrig merged commit 63a5cd8 into nodejs:master Jun 27, 2019

0 of 2 checks passed

Travis CI - Pull Request Build Errored
Details
Travis CI - Branch Build Canceled
Details

@cjihrig cjihrig deleted the cjihrig:cluster branch Jun 27, 2019

targos added a commit that referenced this pull request Jul 2, 2019
doc: clean up isDead() example
This commit removes extra whitespace and some awkward text
containing typos from the cluster worker.isDead() code
sample.

PR-URL: #28421
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos added a commit that referenced this pull request Jul 2, 2019
doc: clean up isDead() example
This commit removes extra whitespace and some awkward text
containing typos from the cluster worker.isDead() code
sample.

PR-URL: #28421
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos referenced this pull request Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.