Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: remove unused using declarations #28422

Closed

Conversation

@danbev
Copy link
Member

commented Jun 25, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@nodejs-github-bot

This comment has been minimized.

@targos
targos approved these changes Jun 25, 2019
@ZYSzys
ZYSzys approved these changes Jun 25, 2019
@Trott
Trott approved these changes Jun 25, 2019
@lpinca
lpinca approved these changes Jun 25, 2019

@lpinca lpinca added the author ready label Jun 25, 2019

@danbev

This comment has been minimized.

Copy link
Member Author

commented Jun 26, 2019

Re-run of failing node-test-commit-freebsd (✔️)

@danbev

This comment has been minimized.

Copy link
Member Author

commented Jun 28, 2019

Landed in d9da0a9.

@danbev danbev closed this Jun 28, 2019

@danbev danbev deleted the danbev:tools_snapshot_builder_unused_using branch Jun 28, 2019

danbev added a commit that referenced this pull request Jun 28, 2019
tools: remove unused using declarations
PR-URL: #28422
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos added a commit that referenced this pull request Jul 2, 2019
tools: remove unused using declarations
PR-URL: #28422
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos added a commit that referenced this pull request Jul 2, 2019
tools: remove unused using declarations
PR-URL: #28422
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos referenced this pull request Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.