Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: replace version with REPLACEME #28431

Closed
wants to merge 1 commit into from

Conversation

@cjihrig
Copy link
Contributor

commented Jun 26, 2019

Node 12.4.0 has already been released. Replace the version with REPLACEME so that the proper version gets inserted at release time.

Refs: #28007

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
doc: replace version with REPLACEME
Node 12.4.0 has already been released. Replace the version with
REPLACEME so that the proper version gets inserted at release
time.

Refs: #28007
@addaleax
Copy link
Member

left a comment

👍 to fast-track

@cjihrig

This comment has been minimized.

Copy link
Contributor Author

commented Jun 26, 2019

@Trott
Trott approved these changes Jun 26, 2019
@danbev

This comment has been minimized.

Copy link
Member

commented Jun 26, 2019

Landed in 5b4a0cb.

@danbev danbev closed this Jun 26, 2019

danbev added a commit that referenced this pull request Jun 26, 2019
doc: replace version with REPLACEME
Node 12.4.0 has already been released. Replace the version with
REPLACEME so that the proper version gets inserted at release
time.

PR-URL: #28431
Refs: #28007
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

@cjihrig cjihrig deleted the cjihrig:replaceme branch Jun 26, 2019

targos added a commit that referenced this pull request Jul 2, 2019
doc: replace version with REPLACEME
Node 12.4.0 has already been released. Replace the version with
REPLACEME so that the proper version gets inserted at release
time.

PR-URL: #28431
Refs: #28007
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targos targos referenced this pull request Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.