Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: context little mem leak fix #28452

Closed
wants to merge 1 commit into from

Conversation

@devnexen
Copy link
Contributor

commented Jun 27, 2019

No description provided.

@joyeecheung
Copy link
Member

left a comment

Would be nicer if we just use a std::unique_ptr for it but LGTM anyway

@nodejs-github-bot

This comment has been minimized.

@Trott
Trott approved these changes Jun 28, 2019

@Trott Trott added the author ready label Jun 30, 2019

Trott added a commit to Trott/io.js that referenced this pull request Jun 30, 2019
src: fix small memory leak
PR-URL: nodejs#28452
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott

This comment has been minimized.

Copy link
Member

commented Jun 30, 2019

Landed in 20d099a.

Thanks for the contribution! 🎉

@Trott Trott closed this Jun 30, 2019

targos added a commit that referenced this pull request Jul 2, 2019
src: fix small memory leak
PR-URL: #28452
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos added a commit that referenced this pull request Jul 2, 2019
src: fix small memory leak
PR-URL: #28452
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos referenced this pull request Jul 2, 2019
cjihrig added a commit to cjihrig/node-1 that referenced this pull request Jul 9, 2019
@cjihrig cjihrig referenced this pull request Jul 9, 2019
2 of 2 tasks complete
cjihrig added a commit to cjihrig/node-1 that referenced this pull request Jul 10, 2019
cjihrig added a commit to cjihrig/node-1 that referenced this pull request Jul 12, 2019
src: manage MakeContext() pointer with unique_ptr
PR-URL: nodejs#28616
Refs: nodejs#28452
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos added a commit that referenced this pull request Jul 20, 2019
src: manage MakeContext() pointer with unique_ptr
PR-URL: #28616
Refs: #28452
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.