Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centos7 ppc64 le v8 test support #28458

Closed

Conversation

@sam-github
Copy link
Member

sam-github commented Jun 27, 2019

one:

tools: move python code out of jenkins shell

https://ci.nodejs.org/job/node-test-commit-v8-linux/configure echoes
python code into tools and runs it. Move these scripts into tools for
better maintainability.

Once this lands and is back-ported into LTS branches a bunch of shell
code can be deleted from the job.

two:

tools: fix v8 testing with devtoolset on ppcle

The devtoolset doesn't use or set the CXX, etc, env vars, so ignore them
if not present.
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
sam-github added 2 commits Jun 27, 2019
The devtoolset doesn't use or set the CXX, etc, env vars, so ignore them
if not present.
https://ci.nodejs.org/job/node-test-commit-v8-linux/configure echoes
python code into tools and runs it. Move these scripts into tools for
better maintainability.

Once this lands and is back-ported into LTS branches a bunch of shell
code can be deleted from the job.
@sam-github sam-github force-pushed the sam-github:centos7-ppc64-le-v8-test-support branch from 1166b09 to c3db2ca Jun 27, 2019
@sam-github sam-github marked this pull request as ready for review Jun 28, 2019
@richardlau

This comment has been minimized.

Copy link
Member

richardlau commented Jun 28, 2019

Are the three new Python scripts meant to be called from an existing Python/shell script?

@sam-github

This comment has been minimized.

Copy link
Member Author

sam-github commented Jun 28, 2019

@richardlau Sorry, pulled the commit message details into the description. I wish github did that for me on multi-commit PRs.

Copy link
Member

mhdawson left a comment

LGTM

@sam-github

This comment has been minimized.

Copy link
Member Author

sam-github commented Jun 28, 2019

Can I fast-track this, @nodejs/build @targos ?

@mhdawson

This comment has been minimized.

Copy link
Member

mhdawson commented Jun 28, 2019

+1 to fast track from me

@mhdawson mhdawson added the fast-track label Jun 28, 2019
@Trott
Trott approved these changes Jun 30, 2019
@danbev

This comment has been minimized.

Copy link
Member

danbev commented Jul 2, 2019

Landed in e669b81, and ed14aa6.

@danbev danbev closed this Jul 2, 2019
danbev added a commit that referenced this pull request Jul 2, 2019
The devtoolset doesn't use or set the CXX, etc, env vars, so ignore them
if not present.

PR-URL: #28458
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danbev added a commit that referenced this pull request Jul 2, 2019
https://ci.nodejs.org/job/node-test-commit-v8-linux/configure echoes
python code into tools and runs it. Move these scripts into tools for
better maintainability.

Once this lands and is back-ported into LTS branches a bunch of shell
code can be deleted from the job.

PR-URL: #28458
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos added a commit that referenced this pull request Jul 2, 2019
The devtoolset doesn't use or set the CXX, etc, env vars, so ignore them
if not present.

PR-URL: #28458
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos added a commit that referenced this pull request Jul 2, 2019
https://ci.nodejs.org/job/node-test-commit-v8-linux/configure echoes
python code into tools and runs it. Move these scripts into tools for
better maintainability.

Once this lands and is back-ported into LTS branches a bunch of shell
code can be deleted from the job.

PR-URL: #28458
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos added a commit that referenced this pull request Jul 2, 2019
The devtoolset doesn't use or set the CXX, etc, env vars, so ignore them
if not present.

PR-URL: #28458
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos added a commit that referenced this pull request Jul 2, 2019
https://ci.nodejs.org/job/node-test-commit-v8-linux/configure echoes
python code into tools and runs it. Move these scripts into tools for
better maintainability.

Once this lands and is back-ported into LTS branches a bunch of shell
code can be deleted from the job.

PR-URL: #28458
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request Jul 2, 2019
@cclauss cclauss added the Python label Jul 20, 2019
@sam-github sam-github deleted the sam-github:centos7-ppc64-le-v8-test-support branch Jul 23, 2019
BethGriggs added a commit that referenced this pull request Nov 19, 2019
The devtoolset doesn't use or set the CXX, etc, env vars, so ignore them
if not present.

PR-URL: #28458
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs added a commit that referenced this pull request Nov 19, 2019
https://ci.nodejs.org/job/node-test-commit-v8-linux/configure echoes
python code into tools and runs it. Move these scripts into tools for
better maintainability.

Once this lands and is back-ported into LTS branches a bunch of shell
code can be deleted from the job.

PR-URL: #28458
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 4, 2019
MylesBorins added a commit that referenced this pull request Dec 17, 2019
The devtoolset doesn't use or set the CXX, etc, env vars, so ignore them
if not present.

PR-URL: #28458
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins added a commit that referenced this pull request Dec 17, 2019
https://ci.nodejs.org/job/node-test-commit-v8-linux/configure echoes
python code into tools and runs it. Move these scripts into tools for
better maintainability.

Once this lands and is back-ported into LTS branches a bunch of shell
code can be deleted from the job.

PR-URL: #28458
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.