Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: merge bootstrap/README.md into BUILDING.md #28465

Closed

Conversation

@rvagg
Copy link
Member

commented Jun 28, 2019

Alternative to #28264 - remove bootstrap/README.md and merge its contents into BUILDING.md so we don't have duplication, conflicts or confusion.

Includes some other minor reorg and tweaks.

/cc @nodejs/build

BUILDING.md Outdated Show resolved Hide resolved
BUILDING.md Outdated Show resolved Hide resolved
@Trott
Trott approved these changes Jun 30, 2019
@trivikr
trivikr approved these changes Jul 1, 2019

@trivikr trivikr added the author ready label Jul 1, 2019

@bzoz
bzoz approved these changes Jul 1, 2019
@trivikr

This comment has been minimized.

@trivikr trivikr removed the author ready label Jul 1, 2019

@rvagg

This comment has been minimized.

Copy link
Member Author

commented Jul 2, 2019

landed in b12528f

@rvagg rvagg closed this Jul 2, 2019

@rvagg rvagg deleted the rvagg:rvagg/combine-bootstrap-and-building-docs branch Jul 2, 2019

rvagg added a commit that referenced this pull request Jul 2, 2019
doc: merge bootstrap/README.md into BUILDING.md
plus some minor tweaks

PR-URL: #28465
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
@rvagg

This comment has been minimized.

Copy link
Member Author

commented Jul 2, 2019

this included a minor boo boo in the link from bootstrap/README.md, addressed in #28504

targos added a commit that referenced this pull request Jul 2, 2019
doc: merge bootstrap/README.md into BUILDING.md
plus some minor tweaks

PR-URL: #28465
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
targos added a commit that referenced this pull request Jul 2, 2019
doc: merge bootstrap/README.md into BUILDING.md
plus some minor tweaks

PR-URL: #28465
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
@targos targos referenced this pull request Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.