Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: address missing paren #28483

Merged
merged 1 commit into from Jul 2, 2019

Conversation

@cjihrig
Copy link
Contributor

commented Jun 30, 2019

The closing paren was missing. Move to using commas instead.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
@Trott
Trott approved these changes Jun 30, 2019
@lpinca
lpinca approved these changes Jun 30, 2019
@cjihrig

This comment has been minimized.

Copy link
Contributor Author

commented Jul 1, 2019

@trivikr
trivikr approved these changes Jul 1, 2019

@trivikr trivikr added the author ready label Jul 1, 2019

doc: address missing paren
The closing paren was missing. Move to using commas instead.

PR-URL: #28483
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

@cjihrig cjihrig force-pushed the cjihrig:missing-paren branch from 71f47b7 to e1f27ef Jul 2, 2019

@cjihrig cjihrig merged commit e1f27ef into nodejs:master Jul 2, 2019

0 of 2 checks passed

Travis CI - Pull Request Build Errored
Details
Travis CI - Branch Build Canceled
Details

@cjihrig cjihrig deleted the cjihrig:missing-paren branch Jul 2, 2019

targos added a commit that referenced this pull request Jul 20, 2019
doc: address missing paren
The closing paren was missing. Move to using commas instead.

PR-URL: #28483
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
This was referenced Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.