Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: use `class ... extends` in perf_hooks.js #28495

Closed
wants to merge 1 commit into from

Conversation

@addaleax
Copy link
Member

commented Jul 1, 2019

Don’t unnecessarily set the protoype afterwards.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
lib: use `class ... extends` in perf_hooks.js
Don’t unnecessarily set the protoype afterwards.
@cjihrig
cjihrig approved these changes Jul 1, 2019
@targos
targos approved these changes Jul 1, 2019
@lpinca
lpinca approved these changes Jul 1, 2019
@nodejs-github-bot

This comment was marked as outdated.

@Trott
Trott approved these changes Jul 1, 2019
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment has been minimized.

@addaleax

This comment has been minimized.

Copy link
Member Author

commented Jul 6, 2019

Landed in 33a8093

@addaleax addaleax closed this Jul 6, 2019

@addaleax addaleax deleted the addaleax:perf-hooks-extends branch Jul 6, 2019

addaleax added a commit that referenced this pull request Jul 6, 2019
lib: use `class ... extends` in perf_hooks.js
Don’t unnecessarily set the protoype afterwards.

PR-URL: #28495
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos added a commit that referenced this pull request Jul 20, 2019
lib: use `class ... extends` in perf_hooks.js
Don’t unnecessarily set the protoype afterwards.

PR-URL: #28495
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.