Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: simplify `process.resourceUsage()` section #28499

Closed

Conversation

@vsemozhetbyt
Copy link
Contributor

commented Jul 1, 2019

Checklist

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Merge options list with its description to reduce redundancy (some possible typos were also fixed and some periods added).

@cjihrig
cjihrig approved these changes Jul 1, 2019
doc/api/process.md Outdated Show resolved Hide resolved
doc/api/process.md Outdated Show resolved Hide resolved
doc/api/process.md Outdated Show resolved Hide resolved
doc/api/process.md Outdated Show resolved Hide resolved
doc/api/process.md Outdated Show resolved Hide resolved
doc/api/process.md Outdated Show resolved Hide resolved
doc/api/process.md Outdated Show resolved Hide resolved
doc/api/process.md Outdated Show resolved Hide resolved

@vsemozhetbyt vsemozhetbyt force-pushed the vsemozhetbyt:doc-process-resourceUsage branch from 3fb53a4 to 9d20a60 Jul 1, 2019

doc: simplify `process.resourceUsage()` section
Merge options list with its description to reduce redundancy
(some possible typos were also fixed and some periods added).

@vsemozhetbyt vsemozhetbyt force-pushed the vsemozhetbyt:doc-process-resourceUsage branch from 9d20a60 to b3671f7 Jul 1, 2019

@trivikr
trivikr approved these changes Jul 1, 2019
@lpinca
lpinca approved these changes Jul 1, 2019
@Trott
Trott approved these changes Jul 1, 2019
@nodejs-github-bot

This comment has been minimized.

@Trott

This comment has been minimized.

Copy link
Member

commented Jul 2, 2019

Since this is a doc-only change, it just needs a lite CI. Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3732/

@Trott

This comment has been minimized.

Copy link
Member

commented Jul 4, 2019

Landed in 344d12c

@Trott Trott closed this Jul 4, 2019

Trott added a commit to Trott/io.js that referenced this pull request Jul 4, 2019
doc: simplify `process.resourceUsage()` section
Merge options list with its description to reduce redundancy
(some possible typos were also fixed and some periods added).

PR-URL: nodejs#28499
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

@vsemozhetbyt vsemozhetbyt deleted the vsemozhetbyt:doc-process-resourceUsage branch Jul 5, 2019

targos added a commit that referenced this pull request Jul 20, 2019
doc: simplify `process.resourceUsage()` section
Merge options list with its description to reduce redundancy
(some possible typos were also fixed and some periods added).

PR-URL: #28499
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.