Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process: refactor unhandledRejection logic #28540

Merged
merged 1 commit into from Jul 7, 2019

Conversation

@cjihrig
Copy link
Contributor

commented Jul 4, 2019

This commit prevents a deprecation warning from being emitted
if the 'unhandledRejection' event was actually handled.

Fixes: #28539

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@cjihrig cjihrig force-pushed the cjihrig:promise branch from c7b9872 to 4091721 Jul 4, 2019

@shisama
shisama approved these changes Jul 5, 2019
@Trott
Trott approved these changes Jul 5, 2019
@nodejs-github-bot

This comment has been minimized.

Copy link

commented Jul 6, 2019

@cjihrig cjihrig added the author ready label Jul 6, 2019

process: refactor unhandledRejection logic
This commit prevents a deprecation warning from being emitted
if the unhandledRejection event was actually handled.

PR-URL: #28540
Fixes: #28539
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

@cjihrig cjihrig force-pushed the cjihrig:promise branch from 4091721 to 7cf6f9e Jul 7, 2019

@cjihrig cjihrig merged commit 7cf6f9e into nodejs:master Jul 7, 2019

1 of 2 checks passed

Travis CI - Pull Request Build Errored
Details
Travis CI - Branch Build Passed
Details

@cjihrig cjihrig deleted the cjihrig:promise branch Jul 7, 2019

targos added a commit that referenced this pull request Jul 20, 2019
process: refactor unhandledRejection logic
This commit prevents a deprecation warning from being emitted
if the unhandledRejection event was actually handled.

PR-URL: #28540
Fixes: #28539
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
This was referenced Jul 23, 2019
ehmicky added a commit to ehmicky/log-process-errors that referenced this pull request Jul 31, 2019
Remove rejectionWarning logic
It's due to a bug introduced in Node 12.6.0 but fixed in 12.7.0

nodejs/node#28540
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.