Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: skip pseudo-tty tests on AIX #28541

Closed

Conversation

@sam-github
Copy link
Member

commented Jul 4, 2019

See: nodejs/build#1820

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@nodejs-github-bot

This comment has been minimized.

@mhdawson
Copy link
Member

left a comment

LGTM, we need to get builds back to green and we'll work to re-enable once we have a solution.

@mhdawson

This comment has been minimized.

Copy link
Member

commented Jul 4, 2019

I'd like to suggest fast tracking this.

@mhdawson mhdawson added the fast-track label Jul 4, 2019

@sam-github

This comment has been minimized.

Copy link
Member Author

commented Jul 4, 2019

Landed in 8619b19

@sam-github sam-github closed this Jul 4, 2019

@sam-github sam-github deleted the sam-github:skip-console-tests-on-aix branch Jul 4, 2019

sam-github added a commit that referenced this pull request Jul 4, 2019
test: skip pseudo-tty tests on AIX
See: nodejs/build#1820

PR-URL: #28541
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
targos added a commit that referenced this pull request Jul 20, 2019
test: skip pseudo-tty tests on AIX
See: nodejs/build#1820

PR-URL: #28541
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
This was referenced Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.