Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test-fs-writeFileSync-invalid-windows #28569

Merged
merged 1 commit into from Jul 11, 2019

Conversation

@Trott
Copy link
Member

commented Jul 5, 2019

Add a known_issues test for the Windows returning ENOTFOUND where EINVAL
is more appropriate. This happens with various functions in the fs
module when an invalid path is used.

Refs: #8987

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
@nodejs-github-bot

This comment has been minimized.

@cjihrig
cjihrig approved these changes Jul 6, 2019
@lpinca
lpinca approved these changes Jul 9, 2019
@lpinca

This comment has been minimized.

Copy link
Member

commented Jul 9, 2019

Why it fails when skipped?

@Trott

This comment has been minimized.

Copy link
Member Author

commented Jul 10, 2019

Why it fails when skipped?

Because known_issues tests are expected to fail. At least one other test uses assert.fail() instead of common.skip() and includes a comment that says to change it to common.skip() when the issue is resolved and the test is moved out of known_issues. So I'll probably do that with this test.

@nodejs-github-bot

This comment has been minimized.

@Trott Trott added the author ready label Jul 10, 2019

test: add test-fs-writeFileSync-invalid-windows
Add a known_issues test for the Windows returning ENOTFOUND where EINVAL
is more appropriate. This happens with various functions in the `fs`
module when an invalid path is used.

Refs: #8987

PR-URL: #28569
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

@Trott Trott force-pushed the Trott:known-8987 branch from cf56cfe to b6e301a Jul 11, 2019

@Trott

This comment has been minimized.

Copy link
Member Author

commented Jul 11, 2019

Landed in b6e301a

@Trott Trott merged commit b6e301a into nodejs:master Jul 11, 2019

0 of 2 checks passed

Travis CI - Pull Request Build Errored
Details
Travis CI - Branch Build Canceled
Details

@Trott Trott deleted the Trott:known-8987 branch Jul 11, 2019

targos added a commit that referenced this pull request Jul 20, 2019
test: add test-fs-writeFileSync-invalid-windows
Add a known_issues test for the Windows returning ENOTFOUND where EINVAL
is more appropriate. This happens with various functions in the `fs`
module when an invalid path is used.

Refs: #8987

PR-URL: #28569
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.