Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: format Unix consistently #28576

Merged
merged 1 commit into from Jul 8, 2019

Conversation

@cjihrig
Copy link
Contributor

commented Jul 6, 2019

Update the API docs to always spell as Unix for consistency.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
@bnoordhuis
Copy link
Member

left a comment

LGTM. Would be nice to have a doc lint rule.

@lpinca
lpinca approved these changes Jul 6, 2019
@cjihrig

This comment has been minimized.

Copy link
Contributor Author

commented Jul 6, 2019

Would be nice to have a doc lint rule.

Agreed. It's a bit annoying that the doc rules exist outside of core.

@Trott
Trott approved these changes Jul 6, 2019
@Trott

This comment has been minimized.

Copy link
Member

commented Jul 6, 2019

Would be nice to have a doc lint rule.

Agreed. It's a bit annoying that the doc rules exist outside of core.

Yeah, I'd be for reversing the flow to make this easier on us. In other words, instead of adding a rule to the remark-lint-prohibited-strings and then bringing it into core, it would be great to add the rule to core and then publish remark-lint-prohibited-strings in case other projects (in the nodejs org in particular) want to use our markdown linting rules (which none of them do as far as I know).

That might also involve undoing some or all of the rollup stuff for lint-md too, though.

@cjihrig

This comment has been minimized.

Copy link
Contributor Author

commented Jul 7, 2019

@cjihrig cjihrig added the author ready label Jul 7, 2019

@mhdawson
Copy link
Member

left a comment

LGTM

doc: format Unix consistently
Update the API docs to always spell as Unix.

PR-URL: #28576
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

@cjihrig cjihrig force-pushed the cjihrig:unix branch from 6792dd1 to e04ee9b Jul 8, 2019

@cjihrig cjihrig merged commit e04ee9b into nodejs:master Jul 8, 2019

@cjihrig cjihrig deleted the cjihrig:unix branch Jul 8, 2019

targos added a commit that referenced this pull request Jul 20, 2019
doc: format Unix consistently
Update the API docs to always spell as Unix.

PR-URL: #28576
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
This was referenced Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.