Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: add markdown lint rule for 'Unix' #28619

Merged
merged 0 commits into from Jul 12, 2019

Conversation

Projects
None yet
8 participants
@Trott
Copy link
Member

commented Jul 10, 2019

A recent PR standardized on 'Unix' rather than 'UNIX' or 'unix'. This
change adds a markdown linting rule to enforce it going forward.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@Trott Trott requested a review from cjihrig Jul 10, 2019

@cjihrig
Copy link
Contributor

left a comment

A recent PR converted all instances of 'unix' and 'UNIX' to 'Unix'
but one instance was missed.

The change was only applied to the API docs, so not strictly missed.

@Trott

This comment has been minimized.

Copy link
Member Author

commented Jul 10, 2019

A recent PR converted all instances of 'unix' and 'UNIX' to 'Unix'
but one instance was missed.

The change was only applied to the API docs, so not strictly missed.

I'll change the text.

@Trott Trott force-pushed the Trott:unix branch from 6afbda2 to 5066137 Jul 10, 2019

@Trott

This comment has been minimized.

Copy link
Member Author

commented Jul 10, 2019

@Trott Trott added the author ready label Jul 10, 2019

@Trott

This comment has been minimized.

Copy link
Member Author

commented Jul 12, 2019

Landed in 7008d78...4276066.

Trott added a commit to Trott/io.js that referenced this pull request Jul 12, 2019

doc: change 'unix' to 'Unix' in ninja guide
A recent PR converted all instances of 'unix' and 'UNIX' to 'Unix'
in the API docs. This commit fixes one instance in the guides in
preparation for a relevant lint rule.

PR-URL: nodejs#28619
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

@Trott Trott closed this Jul 12, 2019

@Trott Trott force-pushed the Trott:unix branch from 5066137 to 4276066 Jul 12, 2019

@Trott Trott deleted the Trott:unix branch Jul 12, 2019

@Trott Trott merged commit 4276066 into nodejs:master Jul 12, 2019

1 check passed

Travis CI - Branch Build Passed
Details

targos added a commit that referenced this pull request Jul 20, 2019

doc: change 'unix' to 'Unix' in ninja guide
A recent PR converted all instances of 'unix' and 'UNIX' to 'Unix'
in the API docs. This commit fixes one instance in the guides in
preparation for a relevant lint rule.

PR-URL: #28619
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

targos added a commit that referenced this pull request Jul 20, 2019

tools: add markdown lint rule for 'Unix'
A recent PR standardized on 'Unix' rather than 'UNIX' or 'unix'. This
change adds a markdown linting rule to enforce it going forward.

PR-URL: #28619
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

This was referenced Jul 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.