Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add missing types #28623

Closed
wants to merge 1 commit into from

Conversation

@lpinca
Copy link
Member

commented Jul 10, 2019

Document the types returned by the readable.readableObjectMode,
writable.writableLength, and writable.writableObjectMode getters.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
@vsemozhetbyt

This comment was marked as resolved.

Copy link
Contributor

commented Jul 10, 2019

There is also one more type missing: writable.writableLength.

doc: add missing types
Document the types returned by the `readable.readableObjectMode`,
`writable.writableLength`, and `writable.writableObjectMode` getters.

@lpinca lpinca force-pushed the lpinca:add/types branch from c3516df to 5e74c61 Jul 10, 2019

@BridgeAR

This comment has been minimized.

@Trott
Trott approved these changes Jul 12, 2019
@Trott

This comment has been minimized.

Copy link
Member

commented Jul 12, 2019

Landed in 28e18cf

@Trott Trott closed this Jul 12, 2019

Trott added a commit to Trott/io.js that referenced this pull request Jul 12, 2019
doc: add missing types
Document the types returned by the `readable.readableObjectMode`,
`writable.writableLength`, and `writable.writableObjectMode` getters.

PR-URL: nodejs#28623
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>

@lpinca lpinca deleted the lpinca:add/types branch Jul 13, 2019

targos added a commit that referenced this pull request Jul 20, 2019
doc: add missing types
Document the types returned by the `readable.readableObjectMode`,
`writable.writableLength`, and `writable.writableObjectMode` getters.

PR-URL: #28623
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This was referenced Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.