Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: relax requirements for setAAD in CCM mode #28624

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
6 participants
@tniessen
Copy link
Member

commented Jul 10, 2019

This was fixed in OpenSSL 1.1.1c (openssl/openssl@b48e3be). The authentication tag can now be specified after decipher.setAAD() was called, matching the behavior of the other supported AEAD modes (GCM, OCB).

Refs: openssl/openssl#7243

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
doc: relax requirements for setAAD in CCM mode
This was fixed in OpenSSL 1.1.1c (openssl/openssl@b48e3be). The
authentication tag can now be specified after setAAD was called,
matching the behavior of the other supported AEAD modes (GCM, OCB).

Refs: openssl/openssl#7243
@lpinca

lpinca approved these changes Jul 10, 2019

@BridgeAR

This comment has been minimized.

@Trott

Trott approved these changes Jul 12, 2019

@Trott

This comment has been minimized.

Copy link
Member

commented Jul 12, 2019

Landed in 9e34035

@Trott Trott closed this Jul 12, 2019

Trott added a commit to Trott/io.js that referenced this pull request Jul 12, 2019

doc: relax requirements for setAAD in CCM mode
This was fixed in OpenSSL 1.1.1c (openssl/openssl@b48e3be). The
authentication tag can now be specified after setAAD was called,
matching the behavior of the other supported AEAD modes (GCM, OCB).

Refs: openssl/openssl#7243

PR-URL: nodejs#28624
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>

targos added a commit that referenced this pull request Jul 20, 2019

doc: relax requirements for setAAD in CCM mode
This was fixed in OpenSSL 1.1.1c (openssl/openssl@b48e3be). The
authentication tag can now be specified after setAAD was called,
matching the behavior of the other supported AEAD modes (GCM, OCB).

Refs: openssl/openssl#7243

PR-URL: #28624
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>

This was referenced Jul 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.