Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: deprecate finished #28679

Closed
wants to merge 12 commits into from
Closed

doc: deprecate finished #28679

wants to merge 12 commits into from

Conversation

@ronag
Copy link
Member

ronag commented Jul 14, 2019

Remove finished from docs. The naming and function is very confusing and misleading. What is finished is actually ended in the streams spec.

Refs: #28651

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@ronag ronag force-pushed the nxtedition:deprecate-finished branch 4 times, most recently from 11a9c1a to 46e9301 Jul 14, 2019
Copy link
Member

benjamingr left a comment

This needs to be docs-deprecated rather than removed from the docs altogether IMO

@ronag ronag force-pushed the nxtedition:deprecate-finished branch from 46e9301 to d967248 Jul 14, 2019
@ronag ronag changed the title http: deprecate finished doc: deprecate finished Jul 14, 2019
@ronag

This comment has been minimized.

Copy link
Member Author

ronag commented Jul 14, 2019

Not quite sure how to docs-deprecate... but I tried... feedback welcome

@benjamingr

This comment has been minimized.

Copy link
Member

benjamingr commented Jul 14, 2019

Does anyone have a strong opinion regarding how we should deprecate this? @mcollina maybe?

(no hurry)

@addaleax

This comment has been minimized.

Copy link
Member

addaleax commented Jul 14, 2019

Does anyone have a strong opinion regarding how we should deprecate this?

I agree that documentation-only deprecating makes the most sense here.

@ronag ronag force-pushed the nxtedition:deprecate-finished branch 2 times, most recently from a97f9fc to cd143ec Jul 14, 2019
doc/api/deprecations.md Outdated Show resolved Hide resolved
doc/api/http.md Outdated Show resolved Hide resolved
doc/api/http.md Outdated Show resolved Hide resolved
doc/api/http2.md Outdated Show resolved Hide resolved
@ronag ronag force-pushed the nxtedition:deprecate-finished branch from cd143ec to b62d036 Aug 1, 2019
@ronag

This comment has been minimized.

Copy link
Member Author

ronag commented Aug 2, 2019

Blocked by #28934. Let's see what happens there first. It's relevant to the deprecation description.

@ronag ronag mentioned this pull request Aug 5, 2019
4 of 4 tasks complete
@ronag

This comment has been minimized.

Copy link
Member Author

ronag commented Aug 5, 2019

fixed @ChALkeR

@ronag ronag force-pushed the nxtedition:deprecate-finished branch from b62d036 to 9d6fbd0 Aug 5, 2019
@ronag

This comment has been minimized.

Copy link
Member Author

ronag commented Aug 5, 2019

@Trott blocked by #28934

This was referenced Aug 6, 2019
@Trott Trott added the blocked label Aug 6, 2019
@ronag ronag force-pushed the nxtedition:deprecate-finished branch 3 times, most recently from aea31b3 to 9a0472a Aug 17, 2019
@ronag

This comment has been minimized.

Copy link
Member Author

ronag commented Aug 17, 2019

@Trott: this is no longer blocked, ping node/http?

ronag added 2 commits Nov 19, 2019
@ronag ronag mentioned this pull request Nov 20, 2019
3 of 4 tasks complete
@ronag

This comment has been minimized.

Copy link
Member Author

ronag commented Nov 20, 2019

@Trott: The doc linting error seems unrelated to this PR. Not sure what's going on there.

doc/api/deprecations.md Outdated Show resolved Hide resolved
ronag and others added 2 commits Nov 20, 2019
Co-Authored-By: Rich Trott <rtrott@gmail.com>
@ronag ronag force-pushed the nxtedition:deprecate-finished branch from b159660 to dcd3724 Nov 20, 2019
@ronag

This comment has been minimized.

Copy link
Member Author

ronag commented Nov 20, 2019

@Trott: Linting pass

@lundibundi

This comment has been minimized.

doc/api/deprecations.md Outdated Show resolved Hide resolved
doc/api/deprecations.md Outdated Show resolved Hide resolved
@Trott
Trott approved these changes Dec 7, 2019
doc/api/deprecations.md Outdated Show resolved Hide resolved
Co-Authored-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR

This comment has been minimized.

BridgeAR added a commit that referenced this pull request Dec 10, 2019
PR-URL: #28679
Refs: #28651
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR

This comment has been minimized.

Copy link
Member

BridgeAR commented Dec 10, 2019

Landed in c6ab3af 🎉

@BridgeAR BridgeAR closed this Dec 10, 2019
targos added a commit that referenced this pull request Dec 10, 2019
PR-URL: #28679
Refs: #28651
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@MylesBorins MylesBorins mentioned this pull request Dec 13, 2019
MylesBorins added a commit that referenced this pull request Dec 16, 2019
This is a security release.

This release includes a single commit, an update to npm to 6.13.4.

For more details about the vulnerability please consult the npm blog:

https://blog.npmjs.org/post/189618601100/binary-planting-with-the-npm-cli

Notable Changes:
* deps:
  - update npm to 6.13.4
    #30904
  - update uvwasi (Anna Henningsen)
    #30745
  - upgrade to libuv 1.34.0 (Colin Ihrig)
    #30783
* doc:
  - docs deprecate http finished (Robert Nagy)
    #28679
* events:
  - add captureRejection option (Matteo Collina)
    #27867
* http:
  - add captureRejection support (Matteo Collina)
    #27867
  - llhttp opt-in insecure HTTP header parsing (Sam Roberts)
    #30567
* http2:
  - implement capture rection for 'request' and 'stream' events (Matteo Collina)
    #27867
* net:
  - implement capture rejections for 'connection' event (Matteo Collina)
    #27867
* repl:
  - support previews by eager evaluating input (Ruben Bridgewater)
    #30811
* stream:
  - add support for captureRejection option (Matteo Collina)
    #27867
* tls:
  - implement capture rejections for 'secureConnection' event (Matteo Collina)
    #27867
  - expose IETF name for current cipher suite (Sam Roberts)
    #30637
* worker:
  - add argv constructor option (legendecas)
    #30559

PR-URL: #30937
MylesBorins added a commit that referenced this pull request Dec 16, 2019
This is a security release.

This release includes a single commit, an update to npm to 6.13.4.

For more details about the vulnerability please consult the npm blog:

https://blog.npmjs.org/post/189618601100/binary-planting-with-the-npm-cli

Notable Changes:
* deps:
  * update npm to 6.13.4
    #30904
  * update uvwasi (Anna Henningsen)
    #30745
  * upgrade to libuv 1.34.0 (Colin Ihrig)
    #30783
* doc:
  * docs deprecate http finished (Robert Nagy)
    #28679
* events:
  * add captureRejection option (Matteo Collina)
    #27867
* http:
  * add captureRejection support (Matteo Collina)
    #27867
  * llhttp opt-in insecure HTTP header parsing (Sam Roberts)
    #30567
* http2:
  * implement capture rection for 'request' and 'stream' events (Matteo Collina)
    #27867
* net:
  * implement capture rejections for 'connection' event (Matteo Collina)
    #27867
* repl:
  * support previews by eager evaluating input (Ruben Bridgewater)
    #30811
* stream:
  * add support for captureRejection option (Matteo Collina)
    #27867
* tls:
  * implement capture rejections for 'secureConnection' event (Matteo Collina)
    #27867
  * expose IETF name for current cipher suite (Sam Roberts)
    #30637
* worker:
  * add argv constructor option (legendecas)
    #30559

PR-URL: #30937
MylesBorins added a commit that referenced this pull request Dec 16, 2019
This is a security release.

For more details about the vulnerability please consult the npm blog:

https://blog.npmjs.org/post/189618601100/binary-planting-with-the-npm-cli

Notable Changes:
* deps:
  * update npm to 6.13.4
    #30904
  * update uvwasi (Anna Henningsen)
    #30745
  * upgrade to libuv 1.34.0 (Colin Ihrig)
    #30783
* doc:
  * docs deprecate http finished (Robert Nagy)
    #28679
* events:
  * add captureRejection option (Matteo Collina)
    #27867
* http:
  * add captureRejection support (Matteo Collina)
    #27867
  * llhttp opt-in insecure HTTP header parsing (Sam Roberts)
    #30567
* http2:
  * implement capture rection for 'request' and 'stream' events (Matteo Collina)
    #27867
* net:
  * implement capture rejections for 'connection' event (Matteo Collina)
    #27867
* repl:
  * support previews by eager evaluating input (Ruben Bridgewater)
    #30811
* stream:
  * add support for captureRejection option (Matteo Collina)
    #27867
* tls:
  * implement capture rejections for 'secureConnection' event (Matteo Collina)
    #27867
  * expose IETF name for current cipher suite (Sam Roberts)
    #30637
* worker:
  * add argv constructor option (legendecas)
    #30559

PR-URL: #30937
MylesBorins added a commit that referenced this pull request Dec 17, 2019
This is a security release.

For more details about the vulnerability please consult the npm blog:

https://blog.npmjs.org/post/189618601100/binary-planting-with-the-npm-cli

Notable Changes:
* deps:
  * update npm to 6.13.4
    #30904
  * update uvwasi (Anna Henningsen)
    #30745
  * upgrade to libuv 1.34.0 (Colin Ihrig)
    #30783
* doc:
  * docs deprecate http finished (Robert Nagy)
    #28679
* events:
  * add captureRejection option (Matteo Collina)
    #27867
* http:
  * add captureRejection support (Matteo Collina)
    #27867
  * llhttp opt-in insecure HTTP header parsing (Sam Roberts)
    #30567
* http2:
  * implement capture rection for 'request' and 'stream' events (Matteo Collina)
    #27867
* net:
  * implement capture rejections for 'connection' event (Matteo Collina)
    #27867
* repl:
  * support previews by eager evaluating input (Ruben Bridgewater)
    #30811
* stream:
  * add support for captureRejection option (Matteo Collina)
    #27867
* tls:
  * implement capture rejections for 'secureConnection' event (Matteo Collina)
    #27867
  * expose IETF name for current cipher suite (Sam Roberts)
    #30637
* worker:
  * add argv constructor option (legendecas)
    #30559

PR-URL: #30937
@RidgeA RidgeA mentioned this pull request Dec 19, 2019
targos added a commit that referenced this pull request Jan 14, 2020
PR-URL: #28679
Refs: #28651
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.