Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
doc: amplify warning for execute callback #28738
Instead of this:
...can we use this instead?:
Micro-nit: Elsewhere in this same document, execute is in back-ticks when referring to the callback:
The `execute` and `complete` callbacks are functions that will be
The `execute` function should avoid making any N-API calls
That second one occurs just a few lines away from one of the uses of execute callback (without back-ticks) in this PR.
So the micro-nit is: Maybe make them all consistent? (Unless they are referring to different things, but in that case, maybe we should change the wording in some places to make that fact more clear?)
Totally non-blocking, but if you're feeling perfectionist, you're welcome!
Removed the trailing spaces myself.