Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: generate openssl config for BSD-x86 #28806

Closed
wants to merge 1 commit into from

Conversation

@bnoordhuis
Copy link
Member

commented Jul 22, 2019

Add BSD-x86 to the list of arches and regenerate everything.

Everything in deps/openssl/config/archs/BSD-x86 is auto-generated,
everything else is manual edits to include the right files in the
right places.

I cheated a little: I didn't check in changes to files for other arches
because they contained mostly churn (updated buildstamps and such.)

Fixes: #20326

build: generate openssl config for BSD-x86
Add BSD-x86 to the list of arches and regenerate everything.

Everything in deps/openssl/config/archs/BSD-x86 is auto-generated,
everything else is manual edits to include the right files in the
right places.

I cheated a little: I didn't check in changes to files for other arches
because they contained mostly churn (updated buildstamps and such.)

Fixes: #20326
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@Trott
Trott approved these changes Jul 24, 2019
Copy link
Member

left a comment

Rubber-stamp LGTM

@Trott

This comment has been minimized.

Copy link
Member

commented Jul 24, 2019

@Trott

This comment has been minimized.

Copy link
Member

commented Jul 25, 2019

@sam-github

This comment has been minimized.

Copy link
Member

commented Jul 25, 2019

@Trott

This comment has been minimized.

Copy link
Member

commented Jul 30, 2019

Technically, this can land (1 approval, more than 7 days open, passing CI) but another review would be nice, especially if it's a little more thorough than my rubber-stamp. @nodejs/collaborators

@lpinca
lpinca approved these changes Jul 30, 2019
Copy link
Member

left a comment

RSLGTM

@emaste

This comment has been minimized.

Copy link

commented Jul 30, 2019

LGTM

Trott added a commit to Trott/io.js that referenced this pull request Jul 30, 2019
build: generate openssl config for BSD-x86
Add BSD-x86 to the list of arches and regenerate everything.

Everything in deps/openssl/config/archs/BSD-x86 is auto-generated,
everything else is manual edits to include the right files in the
right places.

I cheated a little: I didn't check in changes to files for other arches
because they contained mostly churn (updated buildstamps and such.)

Fixes: nodejs#20326

PR-URL: nodejs#28806
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott

This comment has been minimized.

Copy link
Member

commented Jul 30, 2019

Landed in 4a1502b. node-core-utils said it fixed whitespace errors during a git am so I'm going to manually start a node-daily-master to make sure this didn't introduce errors, or at least not any errors that would trip our tests. https://ci.nodejs.org/job/node-daily-master/1629/

@Trott Trott closed this Jul 30, 2019

@Trott

This comment has been minimized.

Copy link
Member

commented Jul 30, 2019

(node-daily-master is green.)

targos added a commit that referenced this pull request Aug 2, 2019
build: generate openssl config for BSD-x86
Add BSD-x86 to the list of arches and regenerate everything.

Everything in deps/openssl/config/archs/BSD-x86 is auto-generated,
everything else is manual edits to include the right files in the
right places.

I cheated a little: I didn't check in changes to files for other arches
because they contained mostly churn (updated buildstamps and such.)

Fixes: #20326

PR-URL: #28806
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BridgeAR BridgeAR referenced this pull request Aug 6, 2019

@bnoordhuis bnoordhuis deleted the bnoordhuis:fix20326 branch Aug 15, 2019

JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
build: generate openssl config for BSD-x86
Add BSD-x86 to the list of arches and regenerate everything.

Everything in deps/openssl/config/archs/BSD-x86 is auto-generated,
everything else is manual edits to include the right files in the
right places.

I cheated a little: I didn't check in changes to files for other arches
because they contained mostly churn (updated buildstamps and such.)

Fixes: nodejs#20326

PR-URL: nodejs#28806
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
build: generate openssl config for BSD-x86
Add BSD-x86 to the list of arches and regenerate everything.

Everything in deps/openssl/config/archs/BSD-x86 is auto-generated,
everything else is manual edits to include the right files in the
right places.

I cheated a little: I didn't check in changes to files for other arches
because they contained mostly churn (updated buildstamps and such.)

Fixes: nodejs#20326

PR-URL: nodejs#28806
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.